Closed Bug 310843 Opened 16 years ago Closed 15 years ago

EM requires the use of integer data for em:type

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

This may be as trivial as the incorrect em:type being written to the extensions
datasource and I don't know what the worst case is... what ever the case the
current docs for everything except multiple item packages do not state that
em:type must be integer data. One example is language packs (see the patch in
bug 307225) - in this case they will have the em:type for an extension when the
following function is used.

http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#634
We are going to need this for bug 285848.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #210646 - Flags: review?(benjamin)
Attachment #210646 - Flags: review?(benjamin) → review+
Fixed on trunk
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.170; previous revision: 1.169
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
>what ever the case the current docs for everything except multiple item packages 
>do not state that em:type must be integer data.
No they do.
http://developer.mozilla.org/en/docs/install.rdf#type
(In reply to comment #3)
> >what ever the case the current docs for everything except multiple item packages 
> >do not state that em:type must be integer data.
> No they do.
> http://developer.mozilla.org/en/docs/install.rdf#type
hmmm... the example on the link you provided is <em:type>2</em:type> which is not integer data so at least it doesn't state by example that it must be integer type data which would be along the lines of <em:type NC:parseType="Integer">4</em:type>
I'm sorry I referred to the description: "An integer value representing ..."
Depends on: 326274
Attachment #210646 - Attachment description: patch → patch (needs patch in Bug 326274 for MOZILLA_1_8_BRANCH)
Verbal a+ from bsmedberg... checked in on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.