310843 - EM requires the use of integer data for em:type

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

This may be as trivial as the incorrect em:type being written to the extensions
datasource and I don't know what the worst case is... what ever the case the
current docs for everything except multiple item packages do not state that
em:type must be integer data. One example is language packs (see the patch in
bug 307225) - in this case they will have the em:type for an extension when the
following function is used.

http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#634

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch (needs patch in Bug 326274 for MOZILLA_1_8_BRANCH)

We are going to need this for bug 285848.

Comment 2

[Robert Strong (they/them - no direct email)]

Fixed on trunk
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.170; previous revision: 1.169

Comment 3

[Nickolay_Ponomarev]

>what ever the case the current docs for everything except multiple item packages 
>do not state that em:type must be integer data.
No they do.
http://developer.mozilla.org/en/docs/install.rdf#type

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to comment #3)
> >what ever the case the current docs for everything except multiple item packages 
> >do not state that em:type must be integer data.
> No they do.
> http://developer.mozilla.org/en/docs/install.rdf#type
hmmm... the example on the link you provided is <em:type>2</em:type> which is not integer data so at least it doesn't state by example that it must be integer type data which would be along the lines of <em:type NC:parseType="Integer">4</em:type>

Comment 5

[Nickolay_Ponomarev]

I'm sorry I referred to the description: "An integer value representing ..."

Comment 6

[Robert Strong (they/them - no direct email)]

Verbal a+ from bsmedberg... checked in on MOZILLA_1_8_BRANCH