310869 - "Warn me if this will disable extensions or themes" in update prefs does not work as stated

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Thomas Rutter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050929 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050929 Firefox/1.4

The option "Warn me if this will disable extensions or themes" in the firefox
update prefs does not do what it should.

The warning only occurs after the update is installed.  There is no way to
uninstall the update once I know extensions are broken.

The warning, if any, should come before the update is installed in order to give
me a chance to cancel the update.

Reproducible: Always

Steps to Reproduce:
1. Install nightly 1.8 branch build from 20050930 (version 1.4)
2. Install an extension compatible with 1.4 but not 1.4.1 (Chris Pederick's Web
Developer Extension at the time of writing this).
3. Automatically update to the next nightly

Actual Results:  
Update goes ahead as normal.  Upon restarting Firefox, the update is installed.
 After the update is installed, I am informed that some of my extensions will no
longer work.  There was warning of this prior to the update being installed, and
there is no way of 'undo'ing the update.

Expected Results:  
Warn me that some of my extensions will no longer work before installing the
software update, giving me an opportunity to cancel the update before it's
installed.

N.B. There is still no way to cancel installation of a downloaded update anyway,
so even if I were warned in advance of installing the update, it can't be
cancelled.  That issue is separate, but dependant, and is raised in bug #310698.

If this can't be fixed in time for a final release, then I would humbly suggest
that we remove the UI for this pref.  This would prevent users from getting the
impression an update can be cancelled if it would break extensions, when in fact
this isn't possible.

Comment 1

[Thomas Rutter]

This _may_ be related to bug #310697, whose status has changed since that update.

Comment 2

[Ria Klaassen (not reading all bugmail)]

The problem is, I see this:
http://img363.imageshack.us/img363/214/incompatible1rh.png
Another testcase?

Comment 3

[Ria Klaassen (not reading all bugmail)]

Oh well, sorry, I'm still sleeping.

Comment 4

[Ria Klaassen (not reading all bugmail)]

I can't make anything else of it than this:
http://img377.imageshack.us/img377/6866/update0wg.png

Comment 5

[Benjamin Smedberg]

This pref *will* work properly for the beta build channel, which will list 1.4
-> 1.4.1 as a major update. The problem is that the build automation for the
nightly channel didn't list this as a major update, due to limitations in the
release infrastructure that are being fixed.

Comment 6

[Darin Fisher]

Yes, I think this bug shows up whenever AUS does not describe the update properly.  

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Should we close this one? Or maybe move it to AUS?

Comment 8

[Robert Strong (they/them - no direct email)]

This should be fixed after bug 324121 lands. If AUS doesn't provide the correct info this would still break but that would be an AUS and not an App Update bug so adding depends.

Comment 9

[Robert Strong (they/them - no direct email)]

Fixed by the checkin of bug 324121.