310899 - richlistitem has confusing selected property

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Simon Bünzli]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051002 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051002 Firefox/1.4.1

Property getters which are used for convenient access to boolean attributes
(values are "true"/"false") are usually used as boolean values in JavaScript.
richlistitem's selected however returns the value as a string which makes the
test (item.selected) always return a true value.

Since the only time this getter is used in richlistbox.xml does it precisely
wrong (and since the same getter in listbox works as you'd expect), I suggest to
make the necessary one-line correction.

Should this however really be intentional, this bug would be about richlistitem
interpreting its own selected property the wrong way, causing thus the
richlistbox' _setItemSelection to be called for each element ever selected.

Reproducible: Always

Steps to Reproduce:
1. Open the Downloads manager and make sure that you've got about 100 items listed.
2. Hit [Down] until you reach the end of the list.
3. Close the Downloads manager.

Actual Results:  
The dialog hangs shortly until _setItemSelection has been called for every
single item.

Expected Results:  
The dialog closes at once.

That this bug is visible at all is thanks to the fix for bug 308068 missing on
the branch. The original code loops over all elements for each formerly selected
element, whereas that patch prevents the loops by doing a null check first.

Comment 1

[Simon Bünzli]

Attachment: one-line fix

Comment 2

[Doron Rosenberg (IBM)]

Comment on attachment 198288 [details] [diff] [review]
one-line fix

need r from a toolkit reviewer

Comment 3

[Doron Rosenberg (IBM)]

checked into trunk.

Need this for API-correctness reasons per mconnor.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 198288 [details] [diff] [review]
one-line fix

moving request to 1.8rc1 since 1.8b5 has shipped.

Comment 5

[Asa Dotzler [:asa]]

mike's gonna land this.

Comment 6

[Mike Connor [:mconnor]]

Landed on branch.