Closed
Bug 310907
Opened 19 years ago
Closed 19 years ago
document "All files downloaded to:" button in DM
Categories
(Firefox Graveyard :: Help Documentation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox1.5
People
(Reporter: steffen.wilberg, Assigned: gidsgoldberg)
Details
(Keywords: fixed1.8, late-l10n)
Attachments
(1 file, 1 obsolete file)
1.00 KB,
patch
|
steffen.wilberg
:
review+
asa
:
approval1.8rc1+
|
Details | Diff | Splinter Review |
The download manager has a button right to the label "All files downloaded to:". We should document that because the button is hard to discover since it doesn't look like a button.
Assignee | ||
Comment 1•19 years ago
|
||
I couldn't find a good way of putting the button label into the description. Also, two other problems with this document I found whilst preparing this patch: 1)<strong> is used in this document, where <em> should be used. 2)The user is advised to 'type' a keyboard shotcut rather than 'press' it. I am happy to fix these issues as well, but I'm guessing they fall outside the scope of this patch.
Attachment #199931 -
Flags: review?(steffen.wilberg)
Reporter | ||
Comment 2•19 years ago
|
||
Comment on attachment 199931 [details] [diff] [review] documents 'All files downloaded to' button > <p>The Download Manager will appear when you download files, when you select s/select/press/ > <span class="menuPath">Tools > Downloads</span>, and when you type > <span class="noUnix">&accelKey;+<kbd>J</kbd></span><span class="unix">&accelKey;+<kbd>Y</kbd></span> >- on your keyboard.</p> >+ </p> There's a dot missing - put that at the end of the line before. >+ <dt>Show Download Folder</dt> >+ <dd>If you have set &brandShortName; to save all downloads to a folder, you >+ can open this folder by clicking the <strong>Folder Name</strong> at the >+ bottom of the Download Manager window.</dd> > </dl> Please add where that pref is located - in <a href="#download_manager_options">Download Manager Options</a>.
Attachment #199931 -
Flags: review?(steffen.wilberg) → review-
Reporter | ||
Comment 3•19 years ago
|
||
Replacing <strong> by <em> is indeed outside the scope of this bug.
Assignee | ||
Comment 4•19 years ago
|
||
Addresses Steffen's points.
Attachment #199931 -
Attachment is obsolete: true
Attachment #200134 -
Flags: review?(steffen.wilberg)
Reporter | ||
Comment 5•19 years ago
|
||
Comment on attachment 200134 [details] [diff] [review] documents 'All files downloaded to' button r=me. I'm not sure why you dropped the first part of your previous patch, but now let's get this one in.
Attachment #200134 -
Flags: review?(steffen.wilberg)
Attachment #200134 -
Flags: review+
Attachment #200134 -
Flags: approval1.8rc1?
Reporter | ||
Updated•19 years ago
|
Updated•19 years ago
|
Attachment #200134 -
Flags: approval1.8rc1? → approval1.8rc1+
Comment 6•19 years ago
|
||
Comment on attachment 200134 [details] [diff] [review] documents 'All files downloaded to' button >+ <a href="#download_manager_options">Download Manager Options</a>, you This should be changed to "Download Manager &pref.pluralCaps;" before checkin.
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•