310909 - event list: double click on event occurrence --- recurrence info not editable (not available)

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051001 Mozilla Sunbird/0.2+

If the event list shows a bounded date range (not "All Events" nor "Future
Events"), then there may be multiple occurrences of a repeating event shown in
the results.  Double clicking on one of these occurences edits the event (at
with the original start date) but with no recurrence info.  In contrast, double
clicking on the occurrence in month view edits the occurrence (at the occurrence
start date) with the recurrence info.

Reproducible: Always

Steps to Reproduce:
1. Create a repeating event, say "weekly test", with multiple occurences within
the next month
2. select event list filter: Events in the next 31 days
3. double click on an occurrence of "weekly test" in month view
   (edit dialog appears, clicking recurrence tab shows recurrence info)
4. double click on an occurrence of "weekly test" in event list
   (edit dialog appears, clicking recurrence tab shows NO recurrence info.

Actual Results:  
No recurrence info in step 4.

Expected Results:  
Recurrence info should appear as in step 3.

Q: should it be possible to edit invididual occurrences?
A: should behave consistently.  
   Editting individual occurrences is a bigger issue.
   I think for 0.3a1, should behave like sunbird 0.2, cannot edit occurrences.

Comment 1

[gekacheka]

Attachment: patch: double click edits parent if it has one

(patch -l -p 2 -i file.patch)

Problem was unifinder double click was editing the occurrence proxy, not the
parent event like the other edit commands.

function monthViewEventDoubleClick edits parent item
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/calendar.js#454


function editEventCommand called by toolbar edit button and context menu edit
item, edits parent item
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/calendar.js#867

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 198299 [details] [diff] [review]
patch: double click edits parent if it has one

No need for the check if .parentItem exists, it will  point to the item itself
if there is no recurrence.
r=mvl without that

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

checked in (without the check)