310939 - Add id attribute to hbox that holds RSS feed and secure site lock

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement)

Description

[Colin Bleckner]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 Firefox/1.0.7

As an extension developer, the right side of the URL bar (where the RSS and
secure site lock icons are displayed) seems like a great place to display other
per-page icons.  Unfortunately the <hbox> that holds those icons doesn't have an
id attribute, making it hard to overlay things in it.  I'd like to see an id
attribute added to that <hbox>.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Colin Bleckner]

Attachment: Adds id to hbox

I think something like this would help (not sure about the id name though).

Comment 2

[Colin Bleckner]

If this were done, I think it'd make sense to do it for Firefox 1.5.  Setting
blocking1.8b5? so that it at least gets considered.

Comment 3

[Scott MacGregor]

this is not a stop ship bug. Would consider a r/sr'ed patch for the id change at
a later date if the firefox MOAs are ok with that.

Comment 4

[Colin Bleckner]

Yeah, I guess 1.8b5 was a little too soon (didn't realize it was coming up so
quickly).

I do think it'd be nice if this change could get before 1.5 ships.  In Firefox
1.0 you can add buttons next to the RSS feed icon without a problem.  Firefox
1.5 moves the RSS feed icon up to the URL bar, but extension authors won't be
able to do the same thing very easily...

Comment 5

[Colin Bleckner]

What can I do to get this change moving forward?  Obviously it won't get into 1.5, can it be added to the trunk?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 198325 [details] [diff] [review]
Adds id to hbox

First step: ask for review!  :)

See http://www.mozilla.org/projects/firefox/review.html

Comment 7

[Asaf Romano (gone)]

Comment on attachment 198325 [details] [diff] [review]
Adds id to hbox

r=mano.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Checked in on the trunk. Thanks Colin!

mozilla/browser/base/content/browser.xul; new revision: 1.272;

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.xul; new revision: 1.268.2.12;