Add id attribute to hbox that holds RSS feed and secure site lock

RESOLVED FIXED in Firefox 2 alpha1

Status

()

Firefox
Toolbars and Customization
--
enhancement
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Colin Bleckner, Assigned: Colin Bleckner)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 alpha1
fixed1.8.1
Points:
---
Bug Flags:
blocking1.8b5 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 Firefox/1.0.7

As an extension developer, the right side of the URL bar (where the RSS and
secure site lock icons are displayed) seems like a great place to display other
per-page icons.  Unfortunately the <hbox> that holds those icons doesn't have an
id attribute, making it hard to overlay things in it.  I'd like to see an id
attribute added to that <hbox>.

Reproducible: Always

Steps to Reproduce:
(Assignee)

Comment 1

13 years ago
Created attachment 198325 [details] [diff] [review]
Adds id to hbox

I think something like this would help (not sure about the id name though).
(Assignee)

Comment 2

13 years ago
If this were done, I think it'd make sense to do it for Firefox 1.5.  Setting
blocking1.8b5? so that it at least gets considered.
Flags: blocking1.8b5?

Comment 3

13 years ago
this is not a stop ship bug. Would consider a r/sr'ed patch for the id change at
a later date if the firefox MOAs are ok with that.
Flags: blocking1.8b5? → blocking1.8b5-

Updated

13 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
Version: unspecified → Trunk
(Assignee)

Comment 4

13 years ago
Yeah, I guess 1.8b5 was a little too soon (didn't realize it was coming up so
quickly).

I do think it'd be nice if this change could get before 1.5 ships.  In Firefox
1.0 you can add buttons next to the RSS feed icon without a problem.  Firefox
1.5 moves the RSS feed icon up to the URL bar, but extension authors won't be
able to do the same thing very easily...
(Assignee)

Comment 5

12 years ago
What can I do to get this change moving forward?  Obviously it won't get into 1.5, can it be added to the trunk?
Comment on attachment 198325 [details] [diff] [review]
Adds id to hbox

First step: ask for review!  :)

See http://www.mozilla.org/projects/firefox/review.html
Attachment #198325 - Flags: review?(bugs.mano)
Comment on attachment 198325 [details] [diff] [review]
Adds id to hbox

r=mano.
Attachment #198325 - Flags: review?(bugs.mano) → review+
Whiteboard: [checkin needed]
Assignee: nobody → colin
Checked in on the trunk. Thanks Colin!

mozilla/browser/base/content/browser.xul; new revision: 1.272;
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox1.6-
mozilla/browser/base/content/browser.xul; new revision: 1.268.2.12;
Keywords: fixed1.8.1
Target Milestone: Firefox 2 → Firefox 2 alpha1
Version: Trunk → 2.0 Branch
You need to log in before you can comment on or make changes to this bug.