310995 - Software Update must delete bug307259.js (the "no-IDN" patch)

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Daniel Veditz [:dveditz]]

Current versions of 1.8 and trunk contain the real fix for bug 307259. The
installers delete the bug307259.js default pref file added by the stop-gap
patch, but Software Update does not.

Sorry if this is a dupe. The installer changes show someone was obviously
thinking about the issue at one point, I just don't want this to get lost and
couldn't find a bug that tracked it.

Comment 1

[Benjamin Smedberg]

Software update doesn't? are you sure?

Comment 2

[Benjamin Smedberg]

http://lxr.mozilla.org/mozilla/source/browser/installer/removed-files.in#17
should be used for both the installer and MAR files.

Comment 3

[Darin Fisher]

I downloaded the latest mozilla1.8 branch MAR file for linux, unpacked it, and
checked the contents of the update.manifest file.  I see the following remove
instruction for the pref file:

  remove "defaults/pref/bug307259.js"

Marking WORKSFORME.

Comment 4

[Chase Phillips]

dveditz, were you saying that whether or not the remove command is in the MAR
file the bug307259.js file is not being deleted?

Comment 5

[Mike Connor [:mconnor]]

clearing blocking flag due to WFM.

Comment 6

[Daniel Veditz [:dveditz]]

(In reply to comment #4)
> dveditz, were you saying that whether or not the remove command is in the MAR
> file the bug307259.js file is not being deleted?

That's exactly what I'm saying. I still have bug307259.js and I've been getting
daily ("nightly") updates on the 1.8 branch.

Comment 7

[Daniel Veditz [:dveditz]]

When I unpack the windows .mar I see a file called "removed-files", with the
line defaults/pref/bug307259.js in it. I don't see a file with a "remove foo"
instruction line if you meant the remove as a literal token.

Is the removal being attempted by a utility that can't handle forward slashes on
windows?

Comment 8

[Daniel Veditz [:dveditz]]

(In reply to comment #7)
> I don't see a file with a "remove foo" instruction line

Of course grep doesn't work on compressed files :-S

update.manifest does contain the line
  remove "defaults/pref/bug307259.js"
but it doesn't appear to work on windows.

Comment 9

[Darin Fisher]

OK, this sounds serious.  I'll investigate this shortly.

Comment 10

[Darin Fisher]

Yup, I'm seeing this bug too.

Comment 11

[Darin Fisher]

OK, I think the problem here is that the incremental updates do not contain the
remove commands!  Perhaps the copy of make_incremental_update.sh used by the
nightly build system is out of date?  Chase?

Comment 12

[Darin Fisher]

This seems like something we need to resolve before shipping updates to beta 1.

Comment 13

[Chase Phillips]

(In reply to comment #11)
> OK, I think the problem here is that the incremental updates do not contain the
> remove commands!  Perhaps the copy of make_incremental_update.sh used by the
> nightly build system is out of date?  Chase?

Yes, it was updated yesterday at bsmedberg's request.  See bug 310715.  Inform
me when you have a change that needs to be placed in it because it isn't updated
automatically.

Comment 14

[Daniel Veditz [:dveditz]]

This is working with partial updates now.