311009 - nsIRequest::IsPending not set to false uniformly

Status: NEW

(Core :: Networking, defect, P5)

Description

[Darin Fisher]

While working with bryner on one of the bfcache bugs, we found that
nsIRequest::isPending is not set to false in a uniform way.  For example, the
HTTP channel sets isPending to false before calling OnStopRequest, while other
channels set isPending to false after calling OnStopRequest.

It would be nice if all channels set IsPending to false before calling
OnStopRequest so that way downstream someone could determine if the channel is
in the process of calling OnStopRequest.  for example, in the case of a
multipart mixed response, it would have been nice if one could inspect the
IsPending state of the partChannel's baseChannel to determine if the
OnStopRequest being called is the last OnStopRequest.  bryner added
nsIMultiPartChannel::IsLastPart to get around this problem.

there may be other cases where being consistent here matters, so we should fix it.

Comment 1

[Darin Fisher]

This bug is partially fixed for the protocol handlers covered by bug 312760.

Comment 2

[Darin Fisher]

-> defaults

Comment 3

[Boris Zbarsky [:bzbarsky]]

I think we should fix this for 1.9...

Comment 4

[Benjamin Smedberg]

biesi, are you interested in taking this?

Comment 5

[Josh Aas]

Honza, Michal, Patrick - do you guys know if this is still an issue?

Comment 6

[Jason Duell]

I don't know if there's inconsistency between protocols anymore, but we're still inconsitstent *within* HTTP: see bug 748117

Comment 7

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258