311169 - typo in sanitize.js pref call (nsIBranch instead of nsIPrefBranch from bug 284086)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Robert Strong (they/them - no direct email)]

http://lxr.mozilla.org/seamonkey/source/browser/base/content/sanitize.js#113

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: fix

Fixes the typo and wraps the call to evictEntries in a try catch (like
everything else there) to prevent the following exception when the deletion is
successful so the button will disable. This was also happening before the typo
was fixed.
Error: uncaught exception: [Exception... "Component returned failure code:
0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)
[nsICacheService.evictEntries]"  nsresult: "0x80520006
(NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)"	location: "JS frame ::
chrome://browser/content/sanitize.js :: anonymous :: line 104"	data: no]

Comment 2

[Giorgio Maone [:ma1]]

This will fix also forced deletion failing on a custom cache directory, as
reported here:
https://bugzilla.mozilla.org/show_bug.cgi?id=296256#c9

Thanks!

Comment 3

[Robert Strong (they/them - no direct email)]

I decided to test sanitize on shutdown with this patch and experienced crashes
about 1 out of every 3 tries when either clicking the cancel or the clear
private data buttons. So, I backed out this patch and I STILL experienced a
crash about 1 out of every 3 tries - so, this crash condition pre-exists this
change.

without the patch
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB10226811X

with the patch
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB10226811X

So, I think the patch is still the right thing to do and there are other
problems causing the crash. I'll look for a bug   tomorrow, file one if
necessary, and try to debug it if no one else beats me to it (please beat me to
it :/ ). Good night.

Comment 4

[Robert Strong (they/them - no direct email)]

Forgot to mention in case talkback is still backed up
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20051004 Firefox/1.4.1
ID:2005100404

Comment 5

[Robert Strong (they/them - no direct email)]

doh! the links above are the same and both without this patch - this is one with
the patch
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB10226190W

g'night gracie

Comment 6

[Robert Strong (they/them - no direct email)]

Checked in on trunk

Checking in mozilla/browser/base/content/sanitize.js;
/cvsroot/mozilla/browser/base/content/sanitize.js,v  <--  sanitize.js
new revision: 1.10; previous revision: 1.9

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 198551 [details] [diff] [review]
fix

Fixes a typo that prevents the sanitize clear cache code from doing its job
properly and also fixes a condition where when it does clear the cache the code
throws an exception which prevents updating of the widget state. This is a safe
/ sane fix.

Comment 8

[Robert Strong (they/them - no direct email)]

Checked in on MOZILLA_1_8_BRANCH

Checking in mozilla/browser/base/content/sanitize.js;
/cvsroot/mozilla/browser/base/content/sanitize.js,v  <--  sanitize.js
new revision: 1.5.2.5; previous revision: 1.5.2.4
done