Closed Bug 311208 Opened 19 years ago Closed 19 years ago

goButtonObserver incorrectly passes a nsURI to dragDropSecurityCheck (dragging a link to the "Go" button doesn't work)

Categories

(Firefox :: General, defect)

1.5.0.x Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Gavin, Assigned: dveditz)

References

()

Details

(Keywords: fixed1.8, regression, Whiteboard: [sg:nse])

Attachments

(1 file)

The checkin for bug 291651 broke the go button onDrop handler by making it pass in a nsURI instead of just the url string. dragDropSecurityCheck expects a URL string and makes it's own nsURI, so this throws. This isn't really a security issue, just broken behavior, since it's a case of throwing when it shouldn't, but I'm marking this security sensitive only because bug 291651 still is. Please make it open to the public if that is not an issue.
This is simple and ought to be fixed.
Assignee: nobody → dveditz
Flags: blocking1.8b5?
Keywords: regression
Whiteboard: [sg:nse]
fixes regression
Attachment #198601 - Flags: review?(mconnor)
Attachment #198601 - Flags: approval1.8b5?
we'll get this in rc1
Flags: blocking1.8rc1+
Flags: blocking1.8b5?
Flags: blocking1.8b5-
Attachment #198601 - Flags: approval1.8b5? → approval1.8rc1?
Attachment #198601 - Flags: review?(mconnor) → review+
Attachment #198601 - Flags: approval1.8rc1? → approval1.8rc1+
fix checked into trunk and 1.8 branch
Group: security
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: