311268 - CalDAV provider should improve URL handling

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Helge Hess]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

When adding a remote calendar, I specified:

  http://myhost/zidestore/dav/helge/Calendar/

as the Calendar collection URL. This results in CalDAV REPORT requests like this:
---snip---
REPORT /zidestore/dav/helge/Calendar// HTTP/1.1
...
---snap---
notice the double-slash at the end.

I would like to suggest to improve the URL processing methods.


Reproducible: Always

Steps to Reproduce:
1. bring up the "subscribe a remote calendar" panel
2. enter a collection URL with a trailing slash

Actual Results:  
an HTTP request with two-slashes at the end of the URL
  REPORT /zidestore/dav/helge/Calendar// HTTP/1.1

Expected Results:  
an HTTP request with a single slash at the end of the URL
  REPORT /zidestore/dav/helge/Calendar/ HTTP/1.1

Don't know what the specification says about //, but avoiding such stuff is
probably a good idea, especially to have normalized URLs on the client (eg for
caches).

Comment 1

[Joey Minta]

Attachment: check for trailing slash first

Checks for trailing slash at the end of caldav urls, prior to actually adding one.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 216944 [details] [diff] [review]
check for trailing slash first

This wants to use charAt, substring or substr instead of manually traversing the string.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Why do we want/need this? A double slash is valid in an url, afaik.

Comment 4

[Bruno Browning]

Even if/though double slashes are valid in a url, this patch does not preclude their use. It merely lets a user entering a URI for a caldav calendar collection (usually) not worry about whether or not she needs a trailing slash, by adding a trailing slash iff the URI doesn't have one. In the hypothetical edge case where the server wants a double slash after the host:port section of the URI, the user can still enter the URI with two trailing slashes. 

Comment 5

[Joey Minta]

Attachment: check for trailing slash first v2

Now using charAt().  This patch still allows double-slashes, if the user entered it, but will never create a double-slash on its own.  That *seems* to be the right behavior here.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 218417 [details] [diff] [review]
check for trailing slash first v2

Sounds like reasonable behavior to me.  r=dmose

Comment 7

[Joey Minta]

Patch checked in.