311311 - Build issues on case sensitive file system

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stefan Wanner]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050917 Camino/1.0a1+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050917 Camino/1.0a1+

Trying to build Camino on 10.4 with case sensitive files system, I found somme
miss spellings in the source code:

It should be AppKit/AppKit.h not Appkit/Appkit.h
It should be Quickdraw.h not QuickDraw.h
It should be nsGfxUtils.h not nsGFXUtils.h


powerbook:~/src/camino swanner$ grep -r "QuickDraw.h\|nsGFXUtils.h\|Appkit.h" *
mozilla/camino/src/bookmarks/BookmarkButton.h:#import <Appkit/Appkit.h>
mozilla/camino/src/bookmarks/BookmarkItem.h:#import <Appkit/Appkit.h>
mozilla/camino/src/bookmarks/BookmarkManager.h:#import <Appkit/Appkit.h>
mozilla/camino/src/bookmarks/BookmarkMenu.h:#import <Appkit/Appkit.h>
mozilla/camino/src/browser/GoMenu.h:#import <Appkit/Appkit.h>
mozilla/camino/src/download/SaveHeaderSniffer.h:#import <Appkit/Appkit.h>
mozilla/camino/src/download/nsDownloadListener.h:#import <Appkit/Appkit.h>
mozilla/camino/src/extensions/ExtendedTableView.h:#import <Appkit/Appkit.h>
mozilla/config/system-headers:QuickDraw.h
mozilla/embedding/browser/cocoa/src/SaveHeaderSniffer.h:#import <Appkit/Appkit.h>
mozilla/embedding/browser/cocoa/src/nsDownloadListener.h:#import <Appkit/Appkit.h>
mozilla/widget/src/cocoa/nsChildView.h:#include <QuickDraw.h>
mozilla/widget/src/cocoa/nsCocoaWindow.mm:#include "nsGFXUtils.h"
mozilla/xpinstall/wizard/mac/src/sdinst.h:#include <QuickDraw.h>
powerbook:~/src/camino swanner$


Reproducible: Always

Steps to Reproduce:
1. Install Mac OS X on a case sensitive file system.
2. Download the latest Camino sorurces from CVS. 
3. Try to build camino.

Actual Results:  
You will get several compiler errors, due to missspelling (wrong case). See
"Details" for affected files.

Expected Results:  
No compiler errors.

Comment 1

[Mark Mentovai]

Yeah, yeah...  See also bug 116709.

Comment 2

[Ben Fowler]

Attachment: Patch for Case sensitive include in nsCocoaWindow.mm (checked in)

Not sure if the filename is intentionally written this way, for
some subtle reason.

This one breaks the build on my system (sources on NetAtalk).

Comment 3

[Mark Mentovai]

Comment on attachment 205712 [details] [diff] [review]
Patch for Case sensitive include in nsCocoaWindow.mm (checked in)

More changes along these lines are needed.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 205712 [details] [diff] [review]
Patch for Case sensitive include in nsCocoaWindow.mm (checked in)

rs=pink

Comment 5

[froodian (Ian Leue)]

Attachment: Patch

Comment 6

[Mark Mentovai]

Comment on attachment 223531 [details] [diff] [review]
Patch

You should also include mozilla/camino/src/extensions/ExtendedTableView.h

Comment 7

[froodian (Ian Leue)]

Attachment: Same as r+ed patch with ExtendedTableView.h (checked in)

Oops, sorry about that.  Since mento r+ed it anyway (and the only difference this patch contains is including extensions/ExtendedTableView.h), going straight for sr.

Comment 8

[Mark Mentovai]

Comment on attachment 223556 [details] [diff] [review]
Same as r+ed patch with ExtendedTableView.h (checked in)

Don't need separate sr for this.

Comment 9

[Mark Mentovai]

Comment on attachment 223556 [details] [diff] [review]
Same as r+ed patch with ExtendedTableView.h (checked in)

Checked in on trunk and MOZILLA_1_8_BRANCH.  Thanks for the patch!

Comment 10

[Mark Mentovai]

Comment on attachment 205712 [details] [diff] [review]
Patch for Case sensitive include in nsCocoaWindow.mm (checked in)

Checked in on MOZILLA_1_8_BRANCH (was on trunk since 0220).

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also bug 339682 (nsChildView.h); since hwaara is reviving CH/NSBrowserView, maybe we should fix the ones in embedding while we're at it, too.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Oops, I meant to add a comment about the entry in system-headers.  The correct capitalization is also present in that file, and since that file is used to do something funky with the headers for the compiler, I would not remove the incorrect capitalization until the entire tree has that header corrected.

http://landfill.mozilla.org/mxr-test/mozilla/search?string=QuickDraw.h&regexp=on&case=on&find=&filter=

Comment 13

[Stuart Morgan]

What's left to do here?

Comment 14

[Stuart Morgan]

Since no-one seems to know, closing FIXED. If there are any new issues with case-sensitive HFS, please file new bugs.