Add directory service key for "C:\Program Files"

RESOLVED FIXED in mozilla1.8beta5

Status

()

Core
XPCOM
P1
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: bsmedberg, Assigned: bsmedberg)

Tracking

({fixed1.8})

Trunk
mozilla1.8beta5
x86
Windows 95
fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
There is a directoryservice key that looks like it should be this, but it
actually points to "Programs" in the Start menu.
(Assignee)

Comment 1

12 years ago
Created attachment 198694 [details] [diff] [review]
Add dirservice key, rev. 1
Attachment #198694 - Flags: review?(darin)
(Assignee)

Updated

12 years ago
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta5

Comment 2

12 years ago
Comment on attachment 198694 [details] [diff] [review]
Add dirservice key, rev. 1

r=darin

It's a shame that these windows specific directory service keys are not
prefixed with "Win" or something like that.
Attachment #198694 - Flags: review?(darin) → review+
(Assignee)

Comment 3

12 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

12 years ago
Comment on attachment 198694 [details] [diff] [review]
Add dirservice key, rev. 1

I'd like this for xulrunner for the nsXULAppInstall implementation, it's very
low-risk since it's adding a new key and I'm using the same codepaths that are
already used.
Attachment #198694 - Flags: approval1.8rc1?
This causes build bustage where CSIDL_PROGRAM_FILES is not defined, exactly as
in bug 241282 comment 22 and following
(Assignee)

Comment 6

12 years ago
smontagu, I'm traveling today and won't have checkin capabilities till this
afternoon, can you land an equivalent patch to the one in bug 241282?
Created attachment 199050 [details] [diff] [review]
bustage fix

No problem. This is the patch I made in my own tree.
Checked in the bustage fix.

Comment 9

12 years ago
please tell us why we need this and if it could possibly have any negative
impact on our primary apps. Also, is it really windows95 only?
(Assignee)

Comment 10

12 years ago
No, this patch is all-windows, the build fix that smontagu created is for old
windows SDKs that don't define the proper constant. The risk is minimal (except
for the build bustage which was fixed) since nobody except XULRunner will be
using this key. The reason I want this patch for 1.8 is so that XULRunner knows
that windows apps belong by default in C:\Program Files (bug 300139).

Updated

12 years ago
Attachment #198694 - Flags: approval1.8rc1? → approval1.8rc1+

Updated

12 years ago
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.