Rename prefs from "browser.xxx" to "browser.display.xxx"

VERIFIED FIXED in M18

Status

P3
normal
VERIFIED FIXED
19 years ago
14 years ago

People

(Reporter: pierre, Assigned: pierre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta2+])

Attachments

(2 attachments)

(Assignee)

Description

19 years ago
This bug is extracted from bug 29304.
The following prefs:
    browser.background_color
    browser.foreground_color
    browser.use_document_fonts
    browser.use_document_colors
    browser.base_font_scaler
    browser.wfe.use_windows_colors
    browser.screen_resolution
should be renamed as "browser.display.xxx" instead of "browser.xxx".

Comment 1

19 years ago
Changing component to Preferences
Assignee: neeti → matt
Component: Preferences: Backend → Preferences

Comment 2

19 years ago
Reassigning as per Don
Assignee: matt → mcafee
Target Milestone: --- → M18

Comment 3

19 years ago
Created attachment 8801 [details] [diff] [review]
patch to rename prefs

Comment 4

19 years ago
I have this change ready to go.
Status: NEW → ASSIGNED

Comment 5

19 years ago
fixed.
QA: try setting some colors in prefs and make sure they
have a "browser.display" prefix.  Oh yeah, color pref window
is busted so ? might need to hand-test.  Or you can just take
my word for it that the changes went in.
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
yep, they're working --testing on linux [opt comm, 2000.05.18.08] with these
prefs:

browser.display.background_color
browser.display.screen_resolution
browser.display.use_document_fonts
Status: RESOLVED → VERIFIED
(Assignee)

Comment 7

19 years ago
Sorry, I was on vacation last week and did not have an opportunity to review the 
code until now. I'm reopening the bug for a small but important code change. The 
goal of this bug (and the result of the long discussion we had in bug 29304) was 
to remove all the RegisterCallback()s from nsPresContext.cpp and replace them 
with a single:
      RegisterCallback("browser.display.", PrefChangedCallback, (void*)this);
and then ask people who want a new pref to cause a reflow when it changes to call 
it "browser.display.<something>".

Chris, it's a 2-line change. Feel free to reassign to me if you want.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

Comment 8

19 years ago
I did the dirty work, looks like we need to turn it on now.
pierre, can you drive this one?
Assignee: mcafee → pierre
Status: REOPENED → NEW
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 9

19 years ago
Marking nsbeta2/fix in hand. Very simple fix...
Keywords: nsbeta2
Whiteboard: [fix in hand]
(Assignee)

Comment 10

19 years ago
Created attachment 10350 [details] [diff] [review]
patch for nsPresContext

Comment 11

19 years ago
Putting on [nsbeta2+] radar.  Patch appears low risk. Approved to checkin for 
patch as shown.
Whiteboard: [fix in hand] → [nsbeta2+]
(Assignee)

Comment 12

19 years ago
Fix checked in nsPresContext.cpp
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago19 years ago
Resolution: --- → FIXED
rubber-stamp vrfy.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.