311423 - uninstall doesn't remove all files (software update files are left behind)

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Darin Fisher]

uninstall doesn't remove all files (software update files are left behind)

these files in particular:

  active-update.xml
  updates.xml
  updates/*

we should probably ship with "empty" versions of these files so that the
installer will know about them and record their existance in the
install_wizard1.log file.

I guess this is a regression since it prevents us from cleanly uninstalling.

Comment 1

[Daniel Veditz [:dveditz]]

> we should probably ship with "empty" versions of these files so that the
> installer will know about them and record their existance

For the generated files you listed the preferred solution would be to add some
logComment lines of the right format to the initial install. You don't need to
ship actual empty versions. see
http://lxr.mozilla.org/mozilla/source/browser/installer/windows/browser.jst#129
(which appears to be out of date).

But that would be a temporary band-aide. Eventually we will software update to
Firefox 2.0 and there's no way to know in advance what new components might be
added. I think we *also* need to build logic into the updater that if we "add" a
file rather than replacing one that already exists then we have to add an entry
to one of the install_wizardx.log files. Maybe this bit should be spun into a
different bug.

Comment 2

[Asa Dotzler [:asa]]

Trying to load balance some here. from darin -> bsmedberg. 

Comment 3

[Darin Fisher]

> I think we *also* need to build logic into the updater that if we "add" a
> file rather than replacing one that already exists then we have to add an entry
> to one of the install_wizardx.log files.

dveditz: See nsPostUpdateWin.js.  It already knows how to add log comments to
the install_wizard log file when new files are added.  The problem is that the
updater cannot record entries about files that are dynamically generated because
it only knows about files that it adds.

Comment 4

[Benjamin Smedberg]

Attachment: Add logComment

Comment 5

[Darin Fisher]

Comment on attachment 199258 [details] [diff] [review]
Add logComment

This looks good to me.	r=darin

Comment 6

[Benjamin Smedberg]

Fixed on trunk

Comment 7

[Scott MacGregor]

Comment on attachment 199258 [details] [diff] [review]
Add logComment

approving the log comment.

Comment 8

[Benjamin Smedberg]

fixed on 1.8 branch