311508 - If the prefwindow is modal, "Use Current Pages" should use the prefwindow opener as the current pages rather than the last focused browser window

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Asaf Romano (gone)]

The "Use Current Pages" button in the preferences window uses the last focuseed
browser window as the "Current Pages". This is OK for instant-apply mode
(default on OS X / GNOME), but sort of broken if the preference window is modal
(default on Windows).

Marking this as a regression since the old prefwindow did use the opener.

Comment 1

[Asaf Romano (gone)]

Attachment: more correctness

Comment 2

[Asaf Romano (gone)]

Checking in general.js;
/cvsroot/mozilla/browser/components/preferences/general.js,v  <--  general.js
new revision: 1.4; previous revision: 1.3
done

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 198883 [details] [diff] [review]
more correctness

Mike, we could use your input here. It's not a blocker so we're not gonna get
this for rc1, but it does seem like something that needs hashing out.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 198883 [details] [diff] [review]
more correctness

This is bad behaviour we should fix.  We fixed similar bugs for 1.0 to not have
this problem.

Renominating for tomorrow's triage meeting.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 198883 [details] [diff] [review]
more correctness

This just isn't something we'd stop ship for and it's not the default
configuration for what we ship. The negative side effect is minor.

Comment 6

[Asa Dotzler [:asa]]

I meant to say, not a common action, not "not the default setting"

Comment 7

[Asaf Romano (gone)]

Comment on attachment 198883 [details] [diff] [review]
more correctness

This ue-regression fix is baking on the trunk for almost two weeks now and also
fixes some brokenness when switching between browser windows in instant-apply
mode (the button becomes disabled when it shouldn't). Renominating.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 198883 [details] [diff] [review]
more correctness

too late for non-critical bugs.

Comment 9

[Asaf Romano (gone)]

Finally
MOZILLA_1_8_BRANCH
Checking in general.js;
/cvsroot/mozilla/browser/components/preferences/general.js,v  <--  general.js
new revision: 1.2.8.2; previous revision: 1.2.8.1
done