last-update.log isn't updated if it already exists

RESOLVED FIXED in mozilla1.8final

Status

()

Toolkit
Application Update
--
major
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: nthomas, Assigned: Darin Fisher)

Tracking

({fixed1.8})

1.8.0 Branch
mozilla1.8final
x86
Windows XP
fixed1.8
Points:
---
Bug Flags:
blocking1.8rc1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
This manifests as the second and subsequent updates not removing the existing
log and replacing it with the one from the just completed updated. Remove the
file and it works fine.

This is the code that preserves the log
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/update/src/nsUpdateService.js.in#331

Steps to reproduce:
1, grab and unpack an archive build like the win32 zip from here
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2005-10-05-07-mozilla1.8/
2, change from beta to nightly channel
3, update once, observe last-update.log is created
4, update again, observe that modification date and file size has not changed
5, remove last-update.log
6, update, log is created
(Assignee)

Comment 1

13 years ago
-> me
Assignee: nobody → darin
Severity: normal → major
Flags: blocking1.8rc1?
Target Milestone: --- → Firefox1.5
(Assignee)

Comment 2

13 years ago
Created attachment 198821 [details] [diff] [review]
v1 patch
Attachment #198821 - Flags: review?(benjamin)

Comment 3

13 years ago
Comment on attachment 198821 [details] [diff] [review]
v1 patch

Bah, I should have caught this the first time 'round.
Attachment #198821 - Flags: review?(benjamin) → review+
(Assignee)

Updated

13 years ago
Attachment #198821 - Flags: approval1.8rc1?
(Assignee)

Comment 4

13 years ago
It shouldn't cause us too much headache provided we get this fix in for 1.5rc1

Only the nightly and betatest channels should be affected by this bug.
Status: NEW → ASSIGNED
(Assignee)

Comment 5

13 years ago
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

13 years ago
Attachment #198821 - Flags: approval1.8rc1? → approval1.8rc1+

Comment 6

13 years ago
adjusting the blocking flag based on our patch approval.
Flags: blocking1.8rc1? → blocking1.8rc1+
(Assignee)

Comment 7

13 years ago
fixed1.8
Keywords: fixed1.8
(Assignee)

Comment 8

13 years ago
crap, this patch didn't work.  it prevents us from writing last-update.log if it does not exist! :-(

see bug 313963
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.