This manifests as the second and subsequent updates not removing the existing log and replacing it with the one from the just completed updated. Remove the file and it works fine. This is the code that preserves the log http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/update/0 Steps to reproduce: 1, grab and unpack an archive build like the win32 zip from here http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2005-10-05-07-mozilla1.8/ 2, change from beta to nightly channel 3, update once, observe last-update.log is created 4, update again, observe that modification date and file size has not changed 5, remove last-update.log 6, update, log is created
Assignee: nobody → darin
Severity: normal → major
Target Milestone: --- → Firefox1.5
Created attachment 198821 [details] [diff] [review] v1 patch
Attachment #198821 - Flags: review?(benjamin)
Comment on attachment 198821 [details] [diff] [review] v1 patch Bah, I should have caught this the first time 'round.
Attachment #198821 - Flags: review?(benjamin) → review+
It shouldn't cause us too much headache provided we get this fix in for 1.5rc1 Only the nightly and betatest channels should be affected by this bug.
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Attachment #198821 - Flags: approval1.8rc1? → approval1.8rc1+
adjusting the blocking flag based on our patch approval.
Flags: blocking1.8rc1? → blocking1.8rc1+
crap, this patch didn't work. it prevents us from writing last-update.log if it does not exist! :-( see bug 313963
You need to log in before you can comment on or make changes to this bug.