Closed Bug 311615 Opened 16 years ago Closed 16 years ago

[FIX]Fix for bug 286491 was a little too aggressive

Categories

(Core :: Layout, defect, P1)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

We're reframing the containing block even if an inline child of the block part
of an {ib} split is being reframed.... There's no need to do that -- the inline
child cannot affect whether the split should exist, no matter what sort of frame
we create for it after reframing.
Attached patch Proposed patchSplinter Review
Attachment #198878 - Flags: superreview?(roc)
Attachment #198878 - Flags: review?(roc)
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
What if a frame was a block and caused splitting, but has now changed to an
inline? E.g.

<span>hello <span id="x">...</span> kitty</span>

document.getElementById('x').style.display = 'block';
...
document.getElementById('x').style.display = 'inline';
> What if a frame was a block and caused splitting, but has now changed to an
> inline?

When it changes to an inline we'll reconstruct the containing block, since we'll
be reframing a block frame whose parent is a special.

So if we have an inline frame whose parent is a special, that means is has a
block sibling causing the splitting.  So it doesn't matter what we do with the
inline -- the splitting will remain.
roc, see comment 3.
Comment on attachment 198878 [details] [diff] [review]
Proposed patch

okay. And I see that in the other case --- inline changing to block --- the
ContentInserted call will reframe the containing block. You might want to
indicate this in a comment somehow or maybe it's just obvious...
Attachment #198878 - Flags: superreview?(roc)
Attachment #198878 - Flags: superreview+
Attachment #198878 - Flags: review?(roc)
Attachment #198878 - Flags: review+
> inline changing to block --- the ContentInserted call will reframe the
> containing block.

Yeah.  I'll add a comment.
Fixed.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Depends on: 347949
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.