311632 - Get LDAP change log replication working again.

Status: RESOLVED WORKSFORME

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

The patch I'm just about to add to bug 231965 will change our ldap replication
method from change log, to download all.

The main reason for this being is that the current change log implementation
prompts repeatedly for username/password, although its not clear what these
should be, and no combination seems to work.

Comment 1

[Ben Campbell]

Maybe it's time to remove the old LDAP change log code? It's been excluded from the build for 13 years or so.

https://searchfox.org/comm-central/source/mailnews/addrbook/src/moz.build

# XXX These files are not being built as they don't work. Bug 311632 should
    # fix them.
    # nsAbLDAPChangeLogQuery.cpp
    # nsAbLDAPChangeLogData.cpp

There's definitely a little bitrot there. I spent ages trying to figure out how on earth their SearchExt() calls were compiling with the wrong arguments, before I realised that they weren't! It'd be nice to avoid further confusion...

Comment 2

[Magnus Melin [:mkmelin]]

None of this exists anymore. LDAP was completely rewritten some years ago.