311646 - Fix compile warnings in mozilla/xpinstall

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Mats Palmgren (inactive)]

Fix compile warnings in mozilla/xpinstall.


nsInstall.cpp:1544: warning: assignment of negative value `MALFORMED_INSTALL'
   to `PRUint32'
nsInstall.cpp:1544: warning: argument of negative value `MALFORMED_INSTALL' to
   `unsigned int'
--
nsInstallTrigger.cpp:184: warning: `nsIScriptGlobalObject*globalObject' might
   be used uninitialized in this function
--
nsInstallFolder.cpp:653: warning: comparison between signed and unsigned
   integer expressions
--
nsInstallFile.cpp:156: warning: unused variable `nsresult rv'
nsInstallExecute.cpp
--
nsXPITriggerInfo.h:89: warning: `nsXPITriggerItem::mFlags' will be initialized
   after
nsXPITriggerInfo.h:86: warning:   `PRBool nsXPITriggerItem::mHashFound'
nsXPITriggerInfo.cpp:100: warning: unused variable `PRUint32 htype'

Comment 1

[Mats Palmgren (inactive)]

Attachment: Patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

+        else if ( curr == PRUint32(kNotFound) )

why not make curr a signed variable?

Comment 3

[Mats Palmgren (inactive)]

Then I would have to make 'start' signed too and then cast
aRelativePath.Length() to PRInt32.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpinstall/src/nsInstallFolder.cpp&rev=1.69&root=/cvsroot&mark=647,673#638

Maybe the real bug is that FindChar() etc should return PRUint32
and that 'kNotFound' should be unsigned, but I guess it's
a bit late to change something like that now.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 198912 [details] [diff] [review]
Patch

r=dveditz

Comment 5

[Mats Palmgren (inactive)]

Checked in to trunk 2005-10-16 08:52 PDT.

-> FIXED