Closed
Bug 311793
Opened 19 years ago
Closed 19 years ago
[patch] getIntPref:withSuccess: always sets success to NO
Categories
(Camino Graveyard :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: englabenny, Assigned: sfraser_bugs)
References
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
806 bytes,
patch
|
sfraser_bugs
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051005 Firefox/1.4.1 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051005 Firefox/1.4.1 The PreferencesManager class has a class method: - (int)getIntPref: (const char*)prefName withSuccess:(BOOL*)outSuccess This method always sets *outSuccess to NO (if not NULL) Reproducible: Always Patch coming
|
Reporter | |
Comment 1•19 years ago
|
||
Patch to use the return value of nsIPref::GetIntPref (as intented from the beginning)
Attachment #199007 -
Flags: review?(mikepinkerton)
|
Assignee | |
Updated•19 years ago
|
Assignee: mikepinkerton → sfraser_bugs
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Assignee | |
Comment 2•19 years ago
|
||
Comment on attachment 199007 [details] [diff] [review] Patch to set the success variable properly I checked this in, as well as fixing getColorPref:withSuccess: which was also inconsistent with setting *outSuccess.
Attachment #199007 -
Flags: review?(mikepinkerton) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed trunk and branch. Thanks for the patch!
You need to log in
before you can comment on or make changes to this bug.
Description
•