Closed
Bug 312008
Opened 21 years ago
Closed 20 years ago
RSS feeds stop loading after connection errors
Categories
(MailNews Core :: Feed Reader, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: palam_rect, Assigned: jwkbugzilla)
References
Details
(Keywords: fixed1.8.0.2, regression, verified1.8.1.3)
Attachments
(1 file)
|
955 bytes,
patch
|
Bienvenu
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
I was using Thunderbird 1.5b1 for some time and it was working fine. But it
suddenly stopped loading new feeds. Even when i force 'Get Messages' its not
loading.
Then i moved to thunderbird 1.5b2 , its again giving the same problem.
Then I deleted my "News & Blogs" account and created a new one. In the new
account , in "Manage subscriptions" window when i added new feed, the status
bar said "verifying feeds" and then the window hanged.
( My network connections are fine and i am able to see the feeds in firefox. )
I hate to to file this bug, since i don't how to reproduce this.
But i don't want to keep quite. I am a software developer and If someone
points me, some resources to debug this issue, I will be very happy to
do that. I like to contribute to mozilla.org.
Reproducible: Always
Comment 1•21 years ago
|
||
What's the url of the feed that hangs? Do you see any exceptions in the
JavaScript console?
| Reporter | ||
Comment 2•21 years ago
|
||
Java script Console gave 3 errors. The first two came while starting
thunderbird.
The last error came , when i try to add new Feed.
( I tried to add feed
http://newsrss.bbc.co.uk/rss/newsonline_uk_edition/technology/rss.xml )
------------------------------
Error: Unknown namespace prefix 'html'. Ruleset ignored due to bad selector.
Source File: chrome://messenger/skin/messageBody.css
Line: 55
------------------------------
Error: syntax error
Source File: file:///home/palanic/thunderbird2/defaults/isp/US/
Line: 1, Column: 1
Source Code:
300: file:///home/palanic/thunderbird2/defaults/isp/US/^
-------------------------------
Error: [Exception... "Component returned failure code: 0x80040111
(NS_ERROR_NOT_AVAILABLE) [nsIXMLHttpRequest.status]" nsresult: "0x80040111
(NS_ERROR_NOT_AVAILABLE)" location: "JS frame ::
chrome://messenger-newsblog/content/Feed.js :: anonymous :: line 174" data: no]
Source File: chrome://messenger-newsblog/content/Feed.js
Line: 174
-------------------------------
Comment 3•21 years ago
|
||
That feed loads fine for me. Do you have problems in -safe-mode also?
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20051012
Thunderbird/1.4.1 ID:2005101205
| Reporter | ||
Comment 4•21 years ago
|
||
Hi,
This issue is not specific to particular feed.
I am getting same error for any feed.
I tried "thunderbird -safe-mode " , It didn't help , its again
giving the same error.
On Googling, I got this link,
http://radio.weblogs.com/0100875/stories/2002/11/01/xmlhttprequestdomparserProblemMultipleSimultaneousRequestsPostingToNetscapepublicmozillaxml.html
But I couldn't understand much.
Is this a javascript engine issue ?
----------------
Error: [Exception... "Component returned failure code: 0x80040111
(NS_ERROR_NOT_AVAILABLE) [nsIXMLHttpRequest.status]" nsresult: "0x80040111
(NS_ERROR_NOT_AVAILABLE)" location: "JS frame ::
chrome://messenger-newsblog/content/Feed.js :: anonymous :: line 174" data: no]
Source File: chrome://messenger-newsblog/content/Feed.js
Line: 174
----------------
| Reporter | ||
Comment 5•21 years ago
|
||
Hi,
Similar bug on Core ,
https://bugzilla.mozilla.org/show_bug.cgi?id=238559
It explained how to use XmlHttpRequest , But i don't
know javascript.
Is there anything wrong, in the source code ?
Line which is giving error in Feed.js
----------------------------------------------------
// if the http status code is a 304, then the feed has not been modified since
we last downloaded it.
feed.downloadCallback.downloaded(feed, request.status == 304 ?
kNewsBlogNoNewItems : kNewsBlogRequestFailure);
----------------------------------------------------
Updated•21 years ago
|
Assignee: mscott → sayrer
| Assignee | ||
Comment 6•20 years ago
|
||
I am experiencing the same problem and I couldn't find any other bug reporting it - confirming. Also tweaking summary.
I have observed the problem in Thunderbird 1.5 RC 1 on Windows XP but from the source code it doesn't look like it is fixed on trunk either. Problem: we can't connect to the server when trying to download a feed. Function onDownloadError in Feed.js is called and tries to access request.status which throws an exception (there was no connection, so there isn't a status). downloadCallback.downloaded() never gets called, so we keep thinking that we are already downloading a feed.
This is a regression from bug 267682, CC'ing mscott and bienvenu. Btw, same status check happens in onParseError where it is safe (we definitely have a status if we came that far) but rather pointless, isn't it?
Solution is trivial: check for errors when accessing request.status, it solves the problem for me. Patch coming soon.
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
Summary: rss feeds are not loading → RSS feeds stop loading after connection errors
| Assignee | ||
Comment 7•20 years ago
|
||
This patch should work for both trunk and 1.5 branch.
Attachment #205828 -
Flags: review?
| Assignee | ||
Updated•20 years ago
|
Attachment #205828 -
Flags: review? → review?(bienvenu)
Updated•20 years ago
|
Attachment #205828 -
Flags: review?(bienvenu) → review+
| Assignee | ||
Updated•20 years ago
|
Attachment #205828 -
Flags: superreview?(mscott)
Comment 8•20 years ago
|
||
*** Bug 320276 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Attachment #205828 -
Flags: superreview?(mscott) → superreview+
Comment 9•20 years ago
|
||
we'll try to get this in a 1.5.0.x release
Target Milestone: --- → Thunderbird2.0
Comment 10•20 years ago
|
||
*** Bug 318777 has been marked as a duplicate of this bug. ***
Comment 11•20 years ago
|
||
By the way, this was checked into the trunk.
Updated•20 years ago
|
Keywords: fixed1.8.1
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed1.8.0.1,
regression
Resolution: --- → FIXED
Version: unspecified → 1.5
Comment 12•20 years ago
|
||
When was this checked in on the branches? I see the keywords, but no comment mentioning it was checked in.
Comment 13•20 years ago
|
||
jay, this was a thunderbird only change.
checked in 01/05.
Comment 14•20 years ago
|
||
Sorry, is there a way I can apply this patch, or need I wait for an update?
| Assignee | ||
Comment 15•20 years ago
|
||
Sure you can. Go into the installation directory of your Thunderbird, in the subdirectory chrome you'll find newsblog.jar. It is just a normal ZIP file, uncompress /content/messenger-newsblog/Feed.js from it. Look for the following line:
feed.downloadCallback.downloaded(feed, request.status == 304 ? kNewsBlogNoNewItems : kNewsBlogRequestFailure);
Replace it by:
var error = kNewsBlogRequestFailure;
try
{
if (request.status == 304)
error = kNewsBlogNoNewItems;
} catch (ex) {}
feed.downloadCallback.downloaded(feed, error);
Then put the file back into newsblog.jar. Make sure to have a copy of the original newsblog.jar - you will need to put it back before updating, otherwise incremental update won't work and you'll have to download the complete application.
Comment 16•20 years ago
|
||
Thanks for the patch which I have installed on my laptop. It runs great and fixes the problem.
Comment 17•20 years ago
|
||
*** Bug 325722 has been marked as a duplicate of this bug. ***
Comment 18•20 years ago
|
||
1.8.0.2 is technically the first release with this Thunderbird fix.
Keywords: fixed1.8.0.1 → fixed1.8.0.2
| Assignee | ||
Updated•19 years ago
|
Assignee: sayrer → trev
Comment 19•19 years ago
|
||
verified fixed thunderbird 2.0.0.0 linux. Disconnected network connection and was able to receive subscriptions after reconnecting. If you can reproduce the problem with a build from <http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2.0.0.0-candidates/>, please report back here.
Keywords: fixed1.8.1 → verified1.8.1.3
Component: RSS → Feed Reader
Product: Thunderbird → MailNews Core
Target Milestone: Thunderbird2.0 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•