31205 - Show Config Info should only display customizations visible in CCK Tool

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-Wizard, enhancement, P3)

Description

[bmartin]

Latest CCK build dated: 03-07-00

O/S: WinNT4.0

Are the following keys needed?:
1. DefaultName = Mozilla
1. Organization = Netscape
2. Department = CCK

_NewConfigName = <configuration name>  (Is this key needed since the 
CustomizationList = is set to the same value?  Also, need to remove the _ from 
the beginning of this key to be consistent with the others that are listed.)

Comment 1

[varada]

The keys that are mentioned are all global variables that can be used and are 
set by the user. Those three were set in the wizardmachine.ini and can be 
removed at anytime. Regardint the _Newconfigname - that is used by the wizard 
and it is displayed in lieu of the ConfigurationList which is not going to be 
displayed anymore and we just have to live with the _ in front of the name ;-).

Comment 2

[bmartin]

Updating the summary from:

"List of Show Summary Problems:"

to:

"Show Config Info should only display customizations visible in CCK Tool"

Comment 3

[bmartin]

Latest Netscape 6 CCK dated: 2000-09-11-15

O/S: Win32

Steps:
1. Download latest Netscape CCK build
2. Install Netscape CCK
3. On CCK Welcome screen, select a configuration
4. Select the Show Config Info Button
5. View contents of the Show Configuration Information dialog

Results:

The Show Configuration Information dialog contains the following unnecessary 
information:
Root	=C:\Program Files\Netscape\CCK\CCKTool\
inifile	=cck.ini
DefaultName	=Netscape
Organization	=Netscape
Department	=CCK
Feedback	=http://home.netscape.com/browsers/6/cck/feedbackcenter.html
FeedbackChoice	=Yes
FeedbackButtonName	=Feedback
CustomizationList	=MyIsp
CreateReadmeIcon	=0
CreateLicenseIcon	=0
IntSetupBgBitmap	=
Company_Name	=
TechSupportNumber	=
NCIFileList	=
NCIFileEditor	=notepad

Comment 4

[varada]

Marking as Future
Sorry for not doing this earlier

Comment 5

[bmartin]

changing from Future to M20 and updating from trivial to major for RTM

The show config info dialog displays unnecessary information.

Comment 6

[selmer (gone)]

This is a nice enhancement that would improve the product some amount.  This is
not a critical (i.e. stop-ship) bug.

Marking as enhancement and moving to future.

Comment 7

[varada]

Marking fixed.
The NCI and account setup values have been removed from the cck.che.

Comment 8

[bmartin]

re-opening....

not all the unnecessary keys have been removed... please look at the list 
detailed above. Thanks.

Comment 9

[msanz]

changing QA contact to blee

Comment 10

[msanz]

changing varada's bugs to shrutiv for CCK

Comment 11

[msanz]

reassigning to shrutiv

Comment 12

[Shruti Vasudevan]

Attachment: Patch file for removing unnecessary keys and sorting the keys

Comment 13

[Shruti Vasudevan]

Patch file to remove unnecessary information in Show Configuration Information 
dialog has been attached.

Comment 14

[Shruti Vasudevan]

Attachment: Patch file to remove unnecessary keys in Show configuration information dialog

Comment 15

[bobj]

patch needs to be updated per comments

Comment 16

[Shruti Vasudevan]

Attachment: Updated patch file

Comment 17

[bobj]

Try to get the patch not to change this line:
  -               str2 = GlobalWidgetArray[i].name;
  +               str2 = GlobalWidgetArray[i].name;

and add a comment of what this code is doing (e.g., "Don't display configs
that CCK cannot modify.")

You should probably add a comment to the area of the code that lists
the configs that can be changed, so that if someone later adds code to
allow modification of one of these, s/he will know to change this code too.

Comment 18

[Shruti Vasudevan]

Attachment: Resubmitting patch with comments

Comment 19

[bobj]

r=bobj
Thanks!

Comment 20

[Shruti Vasudevan]

Marking this as fixed.

Comment 21

[blee]

Verified in 6/15 (respun) b1 bld.