Closed Bug 312199 Opened 19 years ago Closed 19 years ago

HP-UX IPF (IA64, Itanium) porting changes

Categories

(NSPR :: NSPR, defect)

4.4.1
HP
HP-UX
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

References

Details

(Keywords: fixed1.8.1)

Attachments

(3 files, 4 obsolete files)

I received a patch from HP for porting NSPR to HP-UX IPF (IA64, Itanium).
I received this patch from Grace Lu of HP on 9/20/2005. This patch should be applied to NSPR 4.4.1 (cvs tag NSPR_4_4_1_RTM). The following are her comments on the patch (which is referred to as "Fix 0009" in HP). The build environment is modified for compiling on both PA and IA. All changes are added for HP-UX only. RTM naming convention is followed, so that the IA and PA binaries can be stored in RTM structure at the same time.
This is the patch I independently wrote for NSPR 4.6 (CVS tag NSPR_4_6_RTM) on HP-UX IPF. Compared with Grace Lu's patch: 1. I still need to implement the correct RELEASE_OBJDIR_NAME (CPU_ARCH_TAG and COMPILER_TAG) for HP-UX ia64. 2. I need to add +b \$$ORIGIN, (possibly -AP) and +DSblended. 3. The sem_open change for ptsynch.c is already in NSPR 4.6. 4. The stackSize change for ptthread.c is not necessary for NSPR 4.6 because NSPR 4.6 uses the pthread library's default stack size, which is large enough for most applications.
Attached patch Wan-Teh's patch for NSPR 4.6 (obsolete) — Splinter Review
Attachment #199353 - Attachment is obsolete: true
This patch contains some changes for HP-UX Itanium contributed by Grace Lu of HP. 1. nsprpub/configure.in - only define the "hppa" macro on PA-RISC processors. - use .so as the shared library suffix on Itanium - use the _32 tag in NSPR's OBJDIR name for 32-bit Itanium builds (Mozilla doesn't use this) 2. nsprpub/lib/ds/Makefile.in and nsprpub/lib/libc/src/Makefile.in Link libplds4.so and libplc4.so with the +b $ORIGIN linker option. This linker option is equivalent to Solaris's -R $ORIGIN linker option and is similar to Mac OS X's @executable_path. 3. nsprpub/pr/include/md/_hpux.h On Itanium, report the architecture as "ia64" and use .so as shared library suffix. On PA-RISC, report the architecture as "hppa" instead of "hppa1.1" (because the latest version of PA-RISC is 2.0).
Attachment #202447 - Flags: review?(darin)
Attachment #202447 - Flags: review?(darin) → review+
I decided to use the +b $ORIGIN linker option on all NSPR shared libraries, not just libplc4.so and libplds4.so, because I found that it helps the PR_LoadLibrary functions in libnspr4.so to locate shared libraries as well.
Attachment #202445 - Attachment is obsolete: true
Attachment #202727 - Attachment is obsolete: true
I attached the wrong patch. This is the right one.
Attachment #202729 - Attachment is obsolete: true
Attachment #202447 - Attachment is obsolete: true
Comment on attachment 202727 [details] [diff] [review] Wan-Teh's patch for NSPR 4.6, v2 I checked in this patch on the NSPR_4_6_BRANCH for NSPR 4.6.2. Checking in configure; /cvsroot/mozilla/nsprpub/configure,v <-- configure new revision: 1.197.2.1; previous revision: 1.197 done Checking in configure.in; /cvsroot/mozilla/nsprpub/configure.in,v <-- configure.in new revision: 1.199.2.1; previous revision: 1.199 done Checking in pr/include/md/_hpux.h; /cvsroot/mozilla/nsprpub/pr/include/md/_hpux.h,v <-- _hpux.h new revision: 3.18.2.1; previous revision: 3.18 done
Attachment #202727 - Attachment is obsolete: false
The patch for the NSPR tip (NSPR 4.7) was already checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.6.2
Comment on attachment 202727 [details] [diff] [review] Wan-Teh's patch for NSPR 4.6, v2 These changes only affect HP-UX ia64. The reason I want to check them in on the MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH is to keep those Mozilla NSPR branches in sync with the official NSPR_4_6_BRANCH.
Attachment #202727 - Flags: approval1.8.1?
Attachment #202727 - Flags: approval1.8.0.1?
Comment on attachment 202727 [details] [diff] [review] Wan-Teh's patch for NSPR 4.6, v2 When tree reopens for 1.8.0.2 we'll let this in.
Attachment #202727 - Flags: approval1.8.1?
Attachment #202727 - Flags: approval1.8.1+
Attachment #202727 - Flags: approval1.8.0.2?
Attachment #202727 - Flags: approval1.8.0.1?
Attachment #202727 - Flags: approval1.8.0.1-
I checked in the patch on the MOZILLA_1_8_BRANCH. Checking in configure; /cvsroot/mozilla/nsprpub/configure,v <-- configure new revision: 1.78.2.108.4.8; previous revision: 1.78.2.108.4.7 done Checking in configure.in; /cvsroot/mozilla/nsprpub/configure.in,v <-- configure.in new revision: 1.83.2.106.4.8; previous revision: 1.83.2.106.4.7 done Checking in pr/include/md/_hpux.h; /cvsroot/mozilla/nsprpub/pr/include/md/_hpux.h,v <-- _hpux.h new revision: 3.11.4.5.32.1; previous revision: 3.11.4.5 done
Keywords: fixed1.8.1
Flags: blocking1.8.0.2+
Comment on attachment 202727 [details] [diff] [review] Wan-Teh's patch for NSPR 4.6, v2 approved for 1.8.0 branch, a=dveditz
Attachment #202727 - Flags: approval1.8.0.2? → approval1.8.0.2+
I withdrew my blocking1.8.0.2 request.
Flags: blocking1.8.0.2+
Comment on attachment 202727 [details] [diff] [review] Wan-Teh's patch for NSPR 4.6, v2 ok, minus for 1.8.0.2 per wtc
Attachment #202727 - Flags: approval1.8.0.2+ → approval1.8.0.2-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: