Last Comment Bug 312269 - marker leaves poopies along the 4 cardinal directions (on my machine anyway)
: marker leaves poopies along the 4 cardinal directions (on my machine anyway)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: tor
: Hixie (not reading bugmail)
Mentors:
http://p2pmud.com/svgpoop.xml
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-12 23:04 PDT by Bill Burdick
Modified: 2006-06-23 14:43 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase that shows SVG marker poopies (2.13 KB, text/xml)
2005-10-13 09:10 PDT, Bill Burdick
no flags Details
do full invalidate logic on redraw unsuspend (1.19 KB, patch)
2005-10-13 09:40 PDT, tor
scootermorris: review+
Details | Diff | Splinter Review

Description Bill Burdick 2005-10-12 23:04:36 PDT
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1

When I drag around the red circle, the arrow head leaves mouse poop on the screen.

Reproducible: Always

Steps to Reproduce:
1.open url
2.drag red circle around green circle
3.there is no step 3

Actual Results:  
poopies

Expected Results:  
no poopies
Comment 1 Jonathan Watt [:jwatt] 2005-10-12 23:36:44 PDT
Confirming. This also happens on w32, for both GDI+ and cairo. It seems were not
repainting the correct area somehow.
Comment 2 Bill Burdick 2005-10-13 09:10:29 PDT
Created attachment 199421 [details]
testcase that shows SVG marker poopies
Comment 3 tor 2005-10-13 09:40:05 PDT
Created attachment 199423 [details] [diff] [review]
do full invalidate logic on redraw unsuspend
Comment 4 Scooter Morris 2005-10-13 10:22:27 PDT
Comment on attachment 199423 [details] [diff] [review]
do full invalidate logic on redraw unsuspend

Looks fine to me.  I haven't tested to see what the performance implications
might be, though.
Comment 5 tor 2005-10-13 12:22:39 PDT
Might be a bit slower in the case of filtered and/or marked path geometry, but
it's the right thing to do.

Checked in.
Comment 6 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2006-06-23 14:42:20 PDT
[got here from bug 339220] What now does the setting of mUpdateFlags to 0?  Also, why use 0 for a PRBool when you should be using PR_FALSE?
Comment 7 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2006-06-23 14:43:44 PDT
Er, for the PRBool issue, I was looking at the trunk when I shouldn't have been.

Note You need to log in before you can comment on or make changes to this bug.