Closed Bug 312382 Opened 19 years ago Closed 19 years ago

Software Update Fails on Linux

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Thunderbird1.1

People

(Reporter: mscott, Assigned: benjamin)

References

Details

(Keywords: verified1.8)

Attachments

(2 files)

ifdef XPT files [checked in on trunk]
848 bytes, patch
mscott
: review+
mscott
: superreview+
asa
: approval1.8rc1+
Details | Diff | Splinter Review
browser
710 bytes, patch
mscott
: review+
asa
: approval1.8rc1+
Details | Diff | Splinter Review 
The removed files list for Thunderbird:

http://lxr.mozilla.org/mozilla/source/mail/installer/removed-files.in

lists a bunch of xpt files to be removed. This works great on Windows (where we
are now linking all of the xpt files into a single file, mail.xpt), but not so
good on Linux where the xpt files are not linked together.

As a result, when you update a build, these xpt files get removed, and the
resulting linux build doesn't run.

For now, we should add a windows ifdef around the xpt files in the removed files
list.
Depends on: 312380
Note: this isn't a problem on the Mac because of Bug 312380. When that gets
fixed, update on the Mac will break too for the same reason.
Status: NEW → ASSIGNED
Flags: blocking1.8rc1?
Target Milestone: --- → Thunderbird1.1
Assignee: mscott → benjamin

        Attachment #199484 -
        Flags: review?(mscott)

    
    

    
  
Comment on attachment 199484 [details] [diff] [review]
ifdef XPT files [checked in on trunk]

ooops, attachment collision.

At least we both came up with the same fix.

        Attachment #199484 -
        Flags: superreview+

        Attachment #199484 -
        Flags: review?(mscott)

        Attachment #199484 -
        Flags: review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        browser
        — 
          — Splinter Review
      

    


  
Firefox is going to need this, once 312380 is fixed.

        Attachment #199486 -
        Flags: review?(mscott)

    
  

        Attachment #199484 -
        Attachment description: ifdef XPT files → ifdef XPT files [checked in on trunk]

        Attachment #199484 -
        Flags: approval1.8rc1?

    
  

        Attachment #199486 -
        Flags: review?(mscott) → review+

    
  

        Attachment #199486 -
        Flags: approval1.8rc1?

    
    

    
  
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Flags: blocking1.8rc1? → blocking1.8rc1+
Resolution: --- → FIXED

    
  

        Attachment #199484 -
        Flags: approval1.8rc1? → approval1.8rc1+

    
  

        Attachment #199486 -
        Flags: approval1.8rc1? → approval1.8rc1+

    
    

    
  
Fixed on 1.8 branch
Keywords: fixed1.8

    
    

    
  
v.fixed with Linux Thunderbird trunk (10/15 -> 10/16) and branch (10/17 ->
10/18) and Linux Firefox trunk (10/18 -> 10/19) and branch (10/17 -> 10/18). 
Had to hack the channel-pref.js for the TB branch test, since it looks like the
update channel was still set to "beta" for the 10/17 build.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8 → verified1.8

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: