If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use platform specific removed-files lists

RESOLVED WORKSFORME

Status

()

Toolkit
Application Update
RESOLVED WORKSFORME
12 years ago
9 years ago

People

(Reporter: Scott MacGregor, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

12 years ago
Each installer used to have its own platform specific list of files to remove
during installation. 

The new removed-files list is for all platforms.

As such, we currently have a situation where a platform will try to delete files
which don't exist for it. i.e. The Windows updater right now would try to delete
talkback.so.

Does it make sense to go back to platform specific files for the remove lists?

This would:

1) avoid adding platform ifdefs to the remove files list
2) prevent platforms from trying to delete files which don't exist for that
platform (such as windows trying to remove linux files)
3) Might make it easier to manage the lists on a per plaform basis when fixing
issues like 312382.

Thoughts?

Comment 1

12 years ago
I really don't think this is such a good idea: separate manifests tend to cause
one or more manifests to get left out when changes happen... in general I think
that ifdefs in one file are a better solution.
(Reporter)

Comment 2

12 years ago
should we consider ifdefing each part of the file so all the unix files are
together, all the mac files, etc? That would avoid the weird part of Windows
update trying to delete linux libraries.

Comment 3

12 years ago
Normally I would just suggest using the appropriate preprocessor macros so that
we use the same line for linux/win:

http://lxr.mozilla.org/mozilla/source/browser/installer/removed-files.in#33

Updated

12 years ago
Assignee: benjamin → nobody
So are we resolved with the #ifdef option?
(Assignee)

Updated

9 years ago
Product: Firefox → Toolkit
We've been using bsmedberg's suggestion for quite some time now without any significant issues so resolving -> wfm.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.