312388 - Use platform specific removed-files lists

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[Scott MacGregor]

Each installer used to have its own platform specific list of files to remove
during installation. 

The new removed-files list is for all platforms.

As such, we currently have a situation where a platform will try to delete files
which don't exist for it. i.e. The Windows updater right now would try to delete
talkback.so.

Does it make sense to go back to platform specific files for the remove lists?

This would:

1) avoid adding platform ifdefs to the remove files list
2) prevent platforms from trying to delete files which don't exist for that
platform (such as windows trying to remove linux files)
3) Might make it easier to manage the lists on a per plaform basis when fixing
issues like 312382.

Thoughts?

Comment 1

[Benjamin Smedberg]

I really don't think this is such a good idea: separate manifests tend to cause
one or more manifests to get left out when changes happen... in general I think
that ifdefs in one file are a better solution.

Comment 2

[Scott MacGregor]

should we consider ifdefing each part of the file so all the unix files are
together, all the mac files, etc? That would avoid the weird part of Windows
update trying to delete linux libraries.

Comment 3

[Benjamin Smedberg]

Normally I would just suggest using the appropriate preprocessor macros so that
we use the same line for linux/win:

http://lxr.mozilla.org/mozilla/source/browser/installer/removed-files.in#33

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

So are we resolved with the #ifdef option?

Comment 5

[Robert Strong (they/them - no direct email)]

We've been using bsmedberg's suggestion for quite some time now without any significant issues so resolving -> wfm.