312424 - xlib build fails due to missing libxpcom_core.dylib

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[cls]

The xlib build failed to link on OSX because it's missing a reference to
libxpcom_core on the link line.  

c++ -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wno-long-long -fpascal-strings -no-cpp-precomp
-fno-common -fshort-wchar -pipe  -DNDEBUG -DTRIMMED -O2 -I/usr/X11R6/include
-fPIC -arch ppc -o libgfx_xlib.dylib  nsDeviceContextSpecFactoryX.o
nsDeviceContextSpecXlib.o nsDeviceContextXlib.o nsDrawingSurfaceXlib.o
nsFontMetricsXlib.o nsGfxFactoryXlib.o nsImageXlib.o nsRegionXlib.o
nsRenderingContextXlib.o nsScreenXlib.o nsScreenManagerXlib.o
nsPrintOptionsXlib.o nsGCCache.o      -Wl,-dead_strip
../../../dist/lib/libgfxshared_s.a -Wl,-exported_symbols_list
-Wl,../../../../mozilla/build/unix/gnu-ld-scripts/components-export-list -bundle
-L../../../dist/bin -lxlibrgb -L/usr/X11R6/lib -lXext -lX11 -L../../../dist/bin
-L../../../dist/lib -L../../../dist/lib -lplds4 -lplc4 -lnspr4 -lxpcom -lgkgfx 
../../../dist/lib/libunicharutil_s.a
ld: warning can't open dynamic library: @executable_path/libxpcom_core.dylib
(checking for undefined symbols may be affected) (No such file or directory,
errno = 2)
ld: Undefined symbols:
nsCOMPtr_base::assign_from_helper(nsCOMPtr_helper const&, nsID const&)
nsCOMPtr_base::~nsCOMPtr_base()

<pages of missing symbols removed>

Comment 1

[cls]

Attachment: v1 (checked in)

Use MOZ_COMPONENT_LIBS instead of NSPR_LIBS & -lxpcom.

Comment 2

[Benjamin Smedberg]

Comment on attachment 199526 [details] [diff] [review]
v1 (checked in)

xlib-only, doesn't affect any of our default builds

Comment 3

[cls]

Comment on attachment 199526 [details] [diff] [review]
v1 (checked in)

Fixed on the trunk.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 199526 [details] [diff] [review]
v1 (checked in)

Please land your changes on the trunk and verify that it doesn't break anything
before requesting branch approval. Thanks.