312506 - switch ICS exporter to use serializeToICSStream

Status: NEW

(Calendar :: Internal Components, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

serializeToICSStream was added in bug 312381 for performance.  We need to
somehow make it so that both the ICS provider and the ICS exporter can leverage
that code to avoid unnecessary copies, conversions, and XPConnect traversals. 
This could involve using a pipe, a storage stream, or refactoring of
serializeToICSStream, depending on what constraints we want to accept.

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Unfortunately, I do not have cycles to work on Calendar stuff these days (just as it's getting to the good part!), so I am a bad owner for these bugs.  To delete the tragically-large chunk of bugspam, search for gregorianabdication.

Comment 2

[Stefan Sitter [:ssitter]]

Isn't this already fixed by Bug 364841?

Comment 3

[Daniel Boelzle [:dbo]]

IMO only for calICSCalendar. calIcsSerializer.serializeToStream (used by calICsImportExport) still serializes into string, then builds up an output stream.

Comment 4

[Wayne Mery (:wsmwk)]

this is no longer useful, correct?

Comment 5

[Martin Schröder [:mschroeder]]

(In reply to Wayne Mery (:wsmwk) from comment #4)

this is no longer useful, correct?

Comment#3 is still true. At https://searchfox.org/comm-central/source/calendar/base/src/CalIcsSerializer.jsm#43 first the whole iCalendar string is created and afterwards converted to a stream. Maybe this should be put in a new separate issue, so this one can be closed.

Comment 6

[Wayne Mery (:wsmwk)]

I should have been more clear - what I mean is, we probably wouldn't invest effort in this with ical-js being the near term goal?

Comment 7

[Wayne Mery (:wsmwk)]

Magnus will have an opinion, I hope. :)

Comment 8

[Magnus Melin [:mkmelin]]

I don't think it's necessarily tied to ical-js, though after that lots of xpcom could be removed.