312743 - DoneAddingChildren is not called for XTF Elements in XUL if the element doesn't have any child nodes.

Status: RESOLVED FIXED

(Core Graveyard :: XTF, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

DoneAddingChildren is not called for XTF Elements in XUL if the element doesn't
have any child nodes.
Patch coming.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Call DoneAddingChildren also when element doesn't have any children

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: and better to attach the right patch ;)

Comment 3

[Allan Beaufour]

*** Bug 308106 has been marked as a duplicate of this bug. ***

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 199816 [details] [diff] [review]
and better to attach the right patch ;)

Any chance to get this in to 1.8 branch?
This is very low risk, but needed for XForms+XUL.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Checked in to trunk

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 199816 [details] [diff] [review]
and better to attach the right patch ;)

FYI, The 1.8 patch would be 
ofc without the PR_FALSE. Only trunk version of DoneAddingChildren method has
the boolean parameter.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 199816 [details] [diff] [review]
and better to attach the right patch ;)

too late in the game for non-critical bugs without a really compelling case.