Port blocking code gets confused by proxy server ftp://ftp.mozilla.org:21/ is allowed if browsing without a proxy server, but if I configure all FTP traffic to go through a HTTP proxy, then suddenly this URL becomes invalid. The problem I believe is that we hardcode the scheme passed to the nsIIOService::AllowPort call. We should instead use the scheme of the nsIURI that we are loading.
Created attachment 215851 [details] [diff] [review] v1 patch
Comment on attachment 215851 [details] [diff] [review] v1 patch + NS_WARNING("port blocked"); hm... should there really a be a warning for this? I mean... this is something that is only triggered when a user loads a special URL, and they won't see this message.
I added the warning to help developers, who might not realize what's going on otherwise.
12 years ago