Closed
Bug 312811
Opened 19 years ago
Closed 18 years ago
Port blocking code gets confused by proxy server
Categories
(Core :: Networking, defect, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
Attachments
(1 file)
|
3.57 KB,
patch
|
Biesinger
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Port blocking code gets confused by proxy server ftp://ftp.mozilla.org:21/ is allowed if browsing without a proxy server, but if I configure all FTP traffic to go through a HTTP proxy, then suddenly this URL becomes invalid. The problem I believe is that we hardcode the scheme passed to the nsIIOService::AllowPort call. We should instead use the scheme of the nsIURI that we are loading.
|
Assignee | |
Updated•19 years ago
|
Severity: normal → minor
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Updated•18 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #215851 -
Flags: superreview?(bzbarsky)
Attachment #215851 -
Flags: review?(cbiesinger)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 215851 [details] [diff] [review] v1 patch + NS_WARNING("port blocked"); hm... should there really a be a warning for this? I mean... this is something that is only triggered when a user loads a special URL, and they won't see this message.
Attachment #215851 -
Flags: review?(cbiesinger) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
I added the warning to help developers, who might not realize what's going on otherwise.
|
||
Updated•18 years ago
|
Attachment #215851 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Assignee | |
Comment 4•18 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•