stopPropagation() no longer stops drag and drop events on bookmarks-tree widget

RESOLVED INCOMPLETE

Status

()

RESOLVED INCOMPLETE
13 years ago
10 years ago

People

(Reporter: mikek01, Unassigned)

Tracking

({regression})

1.5.0.x Branch
x86
Windows XP
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

793 bytes, application/vnd.mozilla.xul+xml
Details
(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

Since Firefox 1.5 beta 1 (And maybe also in Deer Park), event.stopPropagation()
doesn't stop drag and drop events from propagating when these events are
generated by the bookmarks-tree widget.

Reproducible: Always

Steps to Reproduce:
1. Add an event listener to the bookmarks-tree e.g.
mybookmarkstree.tree.addEventListener("dragdrop", dropped, true);
2. In the dropped event handler (function dropped(event) {...) try
event.stopPropagation()
3. Doesn't stop the event.

Actual Results:  
The default event handler still fires.

Expected Results:  
Default event handler shouldn't fire.
(Reporter)

Updated

13 years ago
Version: unspecified → 1.5 Branch
DOM Events bug for Core?
stopPropagation should stop propagation, not prevent default handlers. 
preventDefault() should prevent default handlers....

As for the rest, when did this regress?  Is there a simple XUL testcase that
shows the problem without me needing to modify chrome that I could use to test
builds on?
(Reporter)

Comment 3

13 years ago
(In reply to comment #2)
> stopPropagation should stop propagation, not prevent default handlers. 
> preventDefault() should prevent default handlers....

AFAIK event.preventDefault() has never worked with the bookmarks-tree widget and
it sure doesn't work with FF 1.5 b1 or b2.

> As for the rest, when did this regress?  Is there a simple XUL testcase that
> shows the problem without me needing to modify chrome that I could use to test
> builds on?

event.stopPopagation() works fine up to FF 1.0.7. I've only tested the problem
with FF 1.5 b1 and b2 and it doesn't work on either of them.

I guess I could write a bit of chrome for you to use as a test.

I was thinking more in terms of which nightly build on ftp://archive.mozilla.org
first shows the problem.  There are 18 months of development between 1.0.x and
1.5.x at this point...
(Reporter)

Comment 5

13 years ago
Sorry Boris, I can't help with your question about nightly builds. All I can
tell you is that it works in 1.0.7 but doesn't work in 1.5 beta 1 and beta 2.

Well... I was asking whether you'd be willing to test with those.  If not, can
you post a piece of chrome (preferably compatible with Seamonkey, since that's
what I have an archive of and can actually run) that would let me test builds?

We're freezing for the release candidate this Sunday, so whatever is not fixed
by then isn't getting fixed, unfortunately.  :(
(Reporter)

Comment 7

13 years ago
Oh well :( I guess we are too late for the code freeze. I'll just try to find a
way to workaround the problem.

Martijn, can you reproduce this?
(In reply to comment #3)
> I guess I could write a bit of chrome for you to use as a test.
That would be very much appreciated!
I would then be able to find a regression range for this bug.
Keywords: regression
(Reporter)

Comment 10

13 years ago
I've already worked around the problem and no one else even seems to have
noticed it, so do you guys really think it's worth the effort?

Created attachment 222033 [details]
testcase

Testcase that works just fine for me in current trunk build, using stoppropagation.
Note that this testcase doesn't work in Mozilla1.7, I can't drop anything in the tree. I'm not really sure why.

Mike, a testcase that would show this bug in current trunk builds would still be appreciated.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.