312853 - "Delete Mail Marked as Junk in Folder" deletes only messages in thread pane per MailView/QuickSearch

Status: RESOLVED INCOMPLETE

(Thunderbird :: Mail Window Front End, defect)

Description

[Kevin Donaker-Ring]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: 1.5 Beta 2

If View | Messages is set to "Unread", any mail marked as Junk that has already
been read does not get deleted when "Delete Mail Marked as Junk in Folder" is
selected from the Tools menu.

Reproducible: Always

Steps to Reproduce:
1. Choose View | Messages | All from the menu
2. Mark some read mail as junk
3. Mark some unread mail as junk
4. Choose View | Messages | Unread from the menu
5. Choose Tools | "Delete Mail Marked as Junk in Folder" from the menu
6. Choose View | Messages | All from the menu

Actual Results:  
Mail marked as junk was still in the folder

Expected Results:  
Junk mail should have been deleted.

Comment 1

[Adam Becevello]

Confirmed on Thunderbird 1.5 beta 2 (Win XP)

However this may be intentional for some reason.  Either way it is different
from the way "Run Filters on Folder" works.  In my testing, the filters will run
on all messages in a folder regardless of the view.  Shouldn't Junk work the
same way?

Comment 2

[Kevin Donaker-Ring]

Obviously, Junk should work the same way. I actually first noticed this in
1.0.6, but I simply haven't had the time to report it. 

Of course, the new behaviour of 1.5 Beta 2 in regards to marking a message as
junk using the message list pane column (clicking to mark as junk automatically
marks the message as "Read") makes following my instructions a bit difficult --
you have to change the status of the Unread messages you marked as Junk back to
Unread. Strangely, messages automatically marked by the Junk filter as Junk are
left unread. But that is perhaps another quibble for another day.

However, that does make it more likely that junk messages will fail to be
deleted by using the "Delete Mail Marked as Junk in Folder" option if the user
also regularly has View | Messages set to Unread.

Comment 3

[Mike Cowperthwaite]

Reproduced with 1.6a1-1015, 1.5b2-1006.  I imagine it also occurs in Seamonkey.
The 'unread' vs. 'read' distinction is just one way this can occur: the deletion 
occurs only for messages that are displayed as a result of the MailView or 
QuickSearch.


(In reply to comment #2)
> the new behaviour of 1.5 Beta 2 in regards to marking a message as
> junk using the message list pane column (clicking to mark as junk
> automatically marks the message as "Read") ...
> Strangely, messages automatically marked by the Junk filter as Junk are
> left unread. But that is perhaps another quibble for another day.
> 
> However, that does make it more likely that junk messages will fail to be
> deleted by using the "Delete Mail Marked as Junk in Folder" option if the user
> also regularly has View | Messages set to Unread.

I've never understood the desire to leave a message that's been manually marked 
as Junk at all visible; that's why I opened bug 220933, which was recently fixed 
-- and now manually-junked messages are marked Read at the same time, so that 
they no longer clamor for attention.  (Whereas detected-Junk messages have a 
nontrivial chance of being falsely identified, and so *should* be left Unread.)  
For those of you who prefer the extra work to achieve the same goal, bug 228949 
is implementing a preference for that behavior.

Similarly, germane to this bug: why don't you turn on the feature in the Junk 
controls to automatically delete, or move to the Junk folder, the messages you 
manually mark?

Comment 4

[Kevin Donaker-Ring]

(In reply to comment #3)

> (In reply to comment #2)

> I've never understood the desire to leave a message that's been manually marked 
> as Junk at all visible; that's why I opened bug 220933, which was recently fixed 
> -- and now manually-junked messages are marked Read at the same time, so that 
> they no longer clamor for attention.  (Whereas detected-Junk messages have a 
> nontrivial chance of being falsely identified, and so *should* be left Unread.)  
> For those of you who prefer the extra work to achieve the same goal, bug 228949 
> is implementing a preference for that behavior.

If they're Junk and clamoring for attention, a simlple click on "Delete Mail
Marked as Junk in Folder" cures that right away! I do somewhat see the logic,
but I want mail that is unread to be shown as unread.

> Similarly, germane to this bug: why don't you turn on the feature in the Junk 
> controls to automatically delete, or move to the Junk folder, the messages you 
> manually mark?

I guess I'm a control freak. There are certain decisions I like to make on my
own, and deleting junk is one of them. Since T-Bird has the option for me to do
so, I'm hoping it will work as expected.

Comment 5

[Wayne Mery (:wsmwk)]

Magnus, what do you think from a UI point of view?  Possible quick fixes:
* remove "in folder". Maybe replace with "in view" or something else.
* disable unless view=all

OTOH, when junk folder selected in folder pane - right click and "empty junk"  works fine regardless of view setting.

Comment 6

[Magnus Melin [:mkmelin]]

I'd say maybe it'd be best best to make it really work on the folder, not on the view. 

In hope of pointing someone (or myself sometime later) in the right direction, see filterFolderForJunk() around here:
http://lxr.mozilla.org/seamonkey/source/mail/base/content/mailCommands.js#699

Comment 7

[Mike Cowperthwaite]

I think this has been fixed by the patch for bug 200138.

Comment 8

[Magnus Melin [:mkmelin]]

Doesn't seem to work at all now for me - filed bug 450897.

Comment 9

[Wayne Mery (:wsmwk)]

can anyone reproduce this?

Comment 10

[Joshua Cranmer [:jcranmer]]

RESOLVED INCOMPLETE due to lack of response to last question. If you feel this change is in error, please respond to this bug with your reasons why.