The default bug view has changed. See this FAQ.

[FIX]two frameset tags cause page to appear blank

VERIFIED FIXED in mozilla1.8rc1

Status

()

Core
Layout: HTML Frames
P1
normal
VERIFIED FIXED
12 years ago
6 years ago

People

(Reporter: fryn, Assigned: bz)

Tracking

({fixed1.8, regression})

Trunk
mozilla1.8rc1
fixed1.8, regression
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8rc1 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051018 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051018 Firefox/1.4.1

if a web page include two frameset tags, the page will appear as a blank white page.

Reproducible: Always
(Reporter)

Comment 1

12 years ago
Boris, could you take a look at this bug, and see what component this bug
belongs to, and maybe create a patch?

Thanks.
(Reporter)

Comment 2

12 years ago
Asa, I know you're busy, but could you refer this bug to someone who could
confirm this and maybe fix it if valid?

Thanks.

Comment 3

12 years ago
The DOM looks correct, so this is probably the correct component.  I see the
problem with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b5)
Gecko/20051018 Firefox/1.4.1.

Marking regression because 1.7.12 works ok on the same machine.

Studio17: attaching a reduced testcase would be a good next step.
Keywords: regression
(Reporter)

Comment 4

12 years ago
Created attachment 200027 [details]
Broken Frameset Test Case
Attachment #200027 - Flags: review?
(Reporter)

Updated

12 years ago
Attachment #200027 - Flags: review?
(Reporter)

Updated

12 years ago
Attachment #200027 - Attachment description: Frameset Test Case → Broken Frameset Test Case
(Reporter)

Comment 5

12 years ago
Created attachment 200028 [details]
Working Frameset Test Case
(Reporter)

Comment 6

12 years ago
i've made two testcases:

one showing a blank page, causing by the bug.

and the other with a modification so it displays correctly.
This is a regression from bug 312097.
Blocks: 312097
Created attachment 200034 [details] [diff] [review]
Patch

Only notify up front on the _first_ frameset we see.
Attachment #200034 - Flags: superreview?(jst)
Attachment #200034 - Flags: review?(jst)
We should get this in on branch.  Stupid logic snafu.  :(
Assignee: nobody → bzbarsky
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.8rc1?
Priority: -- → P1
Target Milestone: --- → mozilla1.8rc1
Summary: two frameset tags cause page to appear blank → [FIX]two frameset tags cause page to appear blank
Attachment #200034 - Flags: superreview?(jst)
Attachment #200034 - Flags: superreview-
Attachment #200034 - Flags: review?(jst)
Attachment #200034 - Flags: review-
Created attachment 200045 [details] [diff] [review]
Better patch

Found some other cases of bug 312097 that weren't really fixed by the patch in
that bug.  I've gone through and made the first (and only the first) frameset
act exactly like body in all the cases that matter now...
Attachment #200034 - Attachment is obsolete: true
Attachment #200045 - Flags: superreview?(jst)
Attachment #200045 - Flags: review?(jst)

Comment 11

12 years ago
please request approval for this patch when it's landed and verified on the
trunk. Thanks.
Comment on attachment 200045 [details] [diff] [review]
Better patch

r+sr=jst
Attachment #200045 - Flags: superreview?(jst)
Attachment #200045 - Flags: superreview+
Attachment #200045 - Flags: review?(jst)
Attachment #200045 - Flags: review+
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Comment on attachment 200045 [details] [diff] [review]
Better patch

Requesting 1.8 branch approval.  This patch basically has two parts:

1)  fix a logic bug in the fix for bug 312097, since the parser allows multiple
framesets in a page, unlike bodies
2)  Make more of the frameset code like the body code from the point of view of
notifications.

I've checked that this doesn't regress any of the other frameset bugs involved,
or anything else I can find.
Attachment #200045 - Flags: approval1.8rc1?

Comment 15

12 years ago
Let's get a trunk verification here. 
Blocks: 309873
Verified using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1)
Gecko/20051020 Firefox/1.6a1.  The URL cited displays fine as does the test case.
Status: RESOLVED → VERIFIED

Updated

12 years ago
Attachment #200045 - Flags: approval1.8rc1? → approval1.8rc1+
(Reporter)

Comment 17

12 years ago
i received this notification:


asa@mozilla.org changed:

          What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200045 [details] [diff]|approval1.8rc1?             |approval1.8rc1+
              Flag|                            |


but this page itself hasnt updated?

Updated

12 years ago
Flags: blocking1.8rc1? → blocking1.8rc1+
(Reporter)

Comment 18

12 years ago
never mind, that took a while though.
(Reporter)

Comment 19

12 years ago
so it's been checked into the trunk but not the branch?
Fixed on branch.

studio17, the branch checkin had to wait on branch approval.
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.