User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051018 Firefox/1.4.1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051018 Firefox/1.4.1 if a web page include two frameset tags, the page will appear as a blank white page. Reproducible: Always
Boris, could you take a look at this bug, and see what component this bug belongs to, and maybe create a patch? Thanks.
Asa, I know you're busy, but could you refer this bug to someone who could confirm this and maybe fix it if valid? Thanks.
The DOM looks correct, so this is probably the correct component. I see the problem with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b5) Gecko/20051018 Firefox/1.4.1. Marking regression because 1.7.12 works ok on the same machine. Studio17: attaching a reduced testcase would be a good next step.
i've made two testcases: one showing a blank page, causing by the bug. and the other with a modification so it displays correctly.
Created attachment 200034 [details] [diff] [review] Patch Only notify up front on the _first_ frameset we see.
We should get this in on branch. Stupid logic snafu. :(
Created attachment 200045 [details] [diff] [review] Better patch Found some other cases of bug 312097 that weren't really fixed by the patch in that bug. I've gone through and made the first (and only the first) frameset act exactly like body in all the cases that matter now...
please request approval for this patch when it's landed and verified on the trunk. Thanks.
Comment on attachment 200045 [details] [diff] [review] Better patch r+sr=jst
Fixed on trunk.
Comment on attachment 200045 [details] [diff] [review] Better patch Requesting 1.8 branch approval. This patch basically has two parts: 1) fix a logic bug in the fix for bug 312097, since the parser allows multiple framesets in a page, unlike bodies 2) Make more of the frameset code like the body code from the point of view of notifications. I've checked that this doesn't regress any of the other frameset bugs involved, or anything else I can find.
Let's get a trunk verification here.
Verified using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051020 Firefox/1.6a1. The URL cited displays fine as does the test case.
i received this notification: email@example.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200045 [details] [diff]|approval1.8rc1? |approval1.8rc1+ Flag| | but this page itself hasnt updated?
never mind, that took a while though.
so it's been checked into the trunk but not the branch?
Fixed on branch. studio17, the branch checkin had to wait on branch approval.