3130 - CR character in prefs crashes

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P2)

Description

[Chris McAfee]

(This bug imported from BugSplat, Netscape's internal bugsystem.  It
was known there as bug #218027
http://scopus.netscape.com/bugsplat/show_bug.cgi?id=218027
Imported into Bugzilla on 02/11/99 19:43)

[from [e-mail]]

When I started netscape it would mysteriously dump a core for no apparent
reason.

I found the problem was that I had set the "identity" attribute for sending
mail through netscape last night.  I had done this by copying my e-mail
address into the X clipboard by triple clicking on the e-mail text and then
pasting this e-mail address into the Netscape's dialog box
(Edit->Preferences->Mail & Groups->Identity->EmailAddress)

Netscape seems to store this address without stripping the trailing newline
character into the file preferences.js.  Here is the line that is the culprit:

user_pref("mail.identity.useremail", "[e-mail]
");

Comment 1

[Chris McAfee]

Yes, I see this problem still.  Giving to malmer to take a look.
Dan, we should probably strip out <CR> in the backend, right?

This is easily reproduced by typing in a return value in the
text area of the privacy pref pane.

Comment 2

[malmer]

Reassigning to mcafee, since I don't have a Gromit build tree.

Here's the diff (based on the Nova tree) that should fix this problem.  It's in
str_escape(), which escapes certain characters when writing out the prefs file.

Index: prefapi.c
===================================================================
RCS file: /m/src/ns/modules/libpref/src/prefapi.c,v
retrieving revision 1.95.4.14.2.30
diff -c -r1.95.4.14.2.30 prefapi.c
*** prefapi.c   1998/10/02 17:01:27     1.95.4.14.2.30
--- prefapi.c   1998/10/02 17:10:42
***************
*** 512,517 ****
--- 512,522 ----
                                q[1] = '\"';
                                q  ;
                  break;
              case '\n':
                  q[0] = '\\';
                                q[1] = '\n';
                                q  ;
                  break;
              default:
                                *q = *p;
                  break;

Comment 3

[Chris McAfee]

We still have libpref in the new world,
reassigning to dp.  Who's libpref owner?

Comment 4

[Suresh Duddi (gone)]

Hubie is the czar of prefs.

Comment 5

[Hubert Shaw]

Fix waiting to checkin to 5.0

Comment 6

[Paul MacQuiddy]

changing to Browser product. MozillaClassic (formerly Mozilla) product is no
longer active.

Comment 7

[Paul MacQuiddy]

per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser

Comment 8

[Hubert Shaw]

Fix checked in, thanks malmer/mcafee

Comment 9

[Paul MacQuiddy]

will verify once prefs UI is available

Comment 10

[leger]

Updating QA Contact from paulmac to cpratt

Comment 11

[cpratt]

In the seamonkey prefs UI, I don't see a "Privacy" option. Any suggestions for
the best way to make sure this is fixed? I typed in some junk with some carraige
returns into the Identity prefs - is that OK? (It didn't crash.)

Comment 12

[cpratt]

Presumed fixed; marking verified.

Comment 13

[leger]

Bulk move of all Pref UI component bugs to new Preferences component.  Pref UI 
component will be deleted.