313023 - confirmuniqueusermatch is case sensitive

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Greg Hendricks]

Email addresses should not be considered case sensitive.

Comment 1

[Frédéric Buclin]

CC: [e-mail] matched Administrator <[e-mail]>

I see no problem here. Marking WFM.

Comment 2

[Greg Hendricks]

(In reply to comment #1)
> CC: [e-mail] matched Administrator <[e-mail]>
> 
> I see no problem here. Marking WFM.

Actually that is the problem, the fact that it has to prompt at all. If the only
difference between the address you typed and the address in the system is case,
it should assume it is correct.

This of course assumes that the profiles table is not case sensitive. However
this should always be the case because emails addresses are identities in the
real world and therefore should not key off of case.

Comment 3

[Frédéric Buclin]

User.pm, line 997:

            # skip confirmation for exact matches
            if ((scalar(@{$users}) == 1)
                && (@{$users}[0]->{'login'} eq $query))
            {

Is "exact matches" case-sensitive or should it consider "foo" and "Foo" as being
"exact"?

Comment 4

[Greg Hendricks]

On my installation (Mysql on Linux) I cannot add a new user of the same email
address where the case is different from the one existing in the database (i.e
GHendricks and ghendricks are treated as the same user). It therefore follows
that unique user match is exact without case sensitivity. 

I am not sure that it is impossible to set up an installation where this would
not be the case, but I think in general it would be silly to do so.

Comment 5

[Greg Hendricks]

Attachment: Patch v1

This really comes down to a policy decision I think, but IMHO it seems very silly to ask a user to confirm that yellow is Yellow or Blue is blue.

This was brought to our attention by a b.n.c user and we have already implemented this since in our system email addresses are not case sensitive.

If anyone can point me to a place where [e-mail] and [e-mail] are two different people, I will withdraw this request.

Comment 6

[Frédéric Buclin]

Comment on attachment 218190 [details] [diff] [review]
Patch v1

r=LpSolit. I will let justdave decide if "exact matches" also involves capitalization.

Comment 7

[Frédéric Buclin]

Not sure we want it for 2.22. justdave?

Comment 8

[Frédéric Buclin]

Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.109; previous revision: 1.108
done