313030 - Popup windows with no scrollbars when reused prevent the scrollbar from appearing on the new website / disallow scrolling

Status: NEW

(Core :: Layout, defect)

Description

[Steve Jacobs (irc: encro)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051017 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051017 Camino/1.0+

Popup windows with no scrollbars when reused prevent the scrollbar from
appearing on the new website. The view isnt notified to reset its disabling of
the scrollbar

May be related to:
https://bugzilla.mozilla.org/show_bug.cgi?id=157306

Reproducible: Always

Steps to Reproduce:
1. Click the attached URL
2. Select a person (apologies for the URL :) I couldnt find a clean demo in
limited timeframe)
3. Use the Popup window to change the site by loading a new URL
Actual Results:  
Scrollbars don't get reset on being notified that the view has changed.

Expected Results:  
Scrollbars should appear as part of the new window

Comment 1

[Steve Jacobs (irc: encro)]

Firefox replicates the same behaviour as Camino.

Comment 2

[Mike Pinkerton (not reading bugmail)]

-> core

Comment 3

[Samuel Sidler (old account; do not CC)]

This also doesn't allow you to scroll a page that is larger than the specified
size (with mouse scroll wheel).

For example, using FF/Win, at http://www.omnigroup.com/applications/omnigraffle/
and clicking on the link under "Feature Comparison Chart" brings up a popup
which doesn't allow scrolling, despite the fact that content is below the bottom
of the pop-up.

Comment 4

[Simon Fraser [no longer active]]

It seems that IE (and Safari) default to "scrollbars=yes", and Gecko to
"scrollbars=no", which makes this problem worse.

So 3 issues here:
1. Can't convert a scrollbar-less window to a window with scrollbars when
loading a new url.
2. Gecko defaults to scrollbars=no
3. If scrollbars are not visible, can't scroll the content with the mouse (e.g.
by drag-scrolling).

Comment 5

[Boris Zbarsky [:bzbarsky]]

> 1. Can't convert a scrollbar-less window to a window with scrollbars when
> loading a new url.

This we should probably fix.  It's a general problem, though -- if there is
already a window open, we ignore the feature string.  I'm pretty sure we have
bugs on that....  Note that some features (eg the close box) it's not clear to
me that we can affect on an already-open window in a general way.  So which
features should be mutable?

> 2. Gecko defaults to scrollbars=no

I believe that we default to no on all features that are not specified if some
features _are_ specified (as in this case).  I was under the impression that IE
did the same; are they not consistent about it?  If we need to change this, the
place to do it is in NS_CALCULATE_CHROME_FLAG_FOR and stuff it calls.

> 3. If scrollbars are not visible, can't scroll the content with the mouse
> (e.g. by drag-scrolling).

This is correct behavior.

Comment 6

[Simon Fraser [no longer active]]

> > 2. Gecko defaults to scrollbars=no
> 
> I believe that we default to no on all features that are not specified if some
> features _are_ specified (as in this case).  I was under the impression that IE
> did the same; are they not consistent about it?  If we need to change this, the
> place to do it is in NS_CALCULATE_CHROME_FLAG_FOR and stuff it calls.

I am going by:
http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp

"scrollbars = { yes | no | 1 | 0 }	Specifies whether to display horizontal and
vertical scroll bars. The default is yes."

Comment 7

[Boris Zbarsky [:bzbarsky]]

Right, but is that the default when no feature string is set at all?  Or also
the default if there is a feature string that doesn't mention scrollbars at all?
 I'll bet money on the former.

Comment 8

[Wevah (Nate Weaver)]

(In reply to comment #7)
>  I'll bet money on the former.

So will I.

"features
[...]This argument is optional; if it is not specified, the new window has all
the standard features."

and

"[...] if the feature appears, |yes| is assumed, and if it doesn't, |no| is
assumed." (If the features argument exists and is not empty.)

From JavaScript: The Definitive Guide, 4th Ed., pp. 672 & 673.

Page 672 also has this to say:

"name [argument]
[...] If this argument names a window that already exists, the open() method
[...] simply returns a reference to the named window. In this case, the
|features| argument is ignored."

So not changing the |scrollbars| feature on existing windows seems to be
expected behavior, though it could still be a bug. (Also, this is obviously just
from one book; I haven't double-checked with other sources.)