313059 - Decide what to do with js.mak

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

There is currently a js.mak file that people are trying to use. Someone recently
reported that trying to use the js file object on a build compiled with it
failed to work correctly (the report said that the resulting binary hung on |new
File("foo.bar")|.

I proposed to remove it, but I see that there's been some interest in the past
to keep it as a working option (see bug 281489). Unless someone speaks up
(preferably with a patch to add JS_HAS_FILE_OBJECT support to it), I'm going to
cvs remove it from the respository...

Comment 1

[Benjamin Smedberg]

I definitely object, unless you plan to add equivcalent options to build
standalone spidermonkey to the mozilla build system --enable-application=js or
spidermonkey or something.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

The more-or-less "supported" way to build the shell is to use Makefile.ref (also
found in js/src). There's a bug on making the standalone js shell using
configure and fun stuff like that, but there's been nothing checked in so far.

It seems that the original post that brought us here was someone who hacked
js.mak to allow for JS_HAS_FILE_OBJECT. Perhaps we could persuade him to submit
a patch and see what's breaking (I'm going to try to test the file object on
Windows now).

Comment 3

[Bob Clary [:bc] (inactive)]

(In reply to comment #1)
> I definitely object, unless you plan to add equivcalent options to build
> standalone spidermonkey to the mozilla build system --enable-application=js or
> spidermonkey or something.

I don't understand. This doesn't exist today does it? js.mak currently has
nothing to do with the mozilla build system and as Blake said make -f
Makefile.ref [BUILD_OPT=1] works to build spidermonkey standalone.

Comment 4

[Aiko]

Currently SpiderMonkey cannot be build with nmake because js.mak wasn't updated in bug 319719; nobody has complained in almost a month. This file is so often behind the times that I believe it's better to face reality: state that GNU make is required to build and remove js.mak.
(The .mdp files are even more outdated and completely useless, btw.)

Comment 5

[Benjamin Smedberg]

I withdrew my objection, I got confused between js.mak and Makefile.ref

Comment 8

[Jason Orendorff [:jorendorff]]

Attachment: delete js.mak

(The patch just deletes js.mak, nothing else.)

Comment 10

[Brian Crowder]

Comment on attachment 323568 [details] [diff] [review]
delete js.mak

Yay!

Comment 11

[Jason Orendorff [:jorendorff]]

Pushed changeset 40d21bb9aeae to mozilla-central.