313141 - Extensions.js looks for "Get more" url and can't find it

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Tom Germeau]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.8b5) Gecko/20051006 Firefox/1.4.1

 Err[JavaScript Error: "uncaught exception: [Exception... "Component returned fa
ilure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getComplexValue]"  n
sresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://moz
apps/content/extensions/extensions.js :: Startup :: line 158"  data: no]"]

Reproducible: Always

Comment 1

[Nickolay_Ponomarev]

Confirming.

The two prefs are extensions.getMoreExtensionsURL and extensions.getMoreThemesURL. Extensions window probably just should hide the link if it can't read the prefs.

See also bug 294342.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Why does this fail? Those prefs are defined in the default firefox pref file. Since you reference bug 294342, I assume you're trying to use the EM with those prefs missing? More details in the description would be useful :). (There really needs to be a toolkit component for this!)

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch

Hi Mike, this is needed mainly for XULRunner apps and it just hides the Get More label if the pref doesn't exist. I also moved the Find Updates button since the resizer prevents it from aligning right. Distinguishing between the buttons that only apply to a selected item vs. buttons that apply to all items (e.g. Find Updates) will be done when the ui is rewritten.

Comment 4

[Robert Strong (they/them - no direct email)]

I forgot to mention that I ran the ui change by beltzner and he was fine with it

Comment 5

[Robert Strong (they/them - no direct email)]

Fixed on trunk

Comment 6

[Robert Strong (they/them - no direct email)]

Fixed on MOZILLA_1_8_BRANCH

Comment 7

[Peter van der Woude [:Peter6]]

Robert, I'm getting

ExtensionManager:_finishOperations - failure, catching exception - lineno: 1576 - file: undefined - [Exception... "Component returned failure code: 0x80570019 (NS_ERROR_XPC_CANT_CREATE_WN) [nsIJSCID.getService]"  nsresult: "0x80570019 (NS_ERROR_XPC_CANT_CREATE_WN)"  location: "JS frame :: file:///C:/Programmas/Firefox/ff30trunk/firefox/components/nsExtensionManager.js :: anonymous :: line 1576"  data: no]

using

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060125 Firefox/1.6a1 ID:2006012512

Comment 8

[Robert Strong (they/them - no direct email)]

(In reply to comment #7)
> Robert, I'm getting
> 
> ExtensionManager:_finishOperations - failure, catching exception - lineno: 1576
> - file: undefined - [Exception... "Component returned failure code: 0x80570019
> (NS_ERROR_XPC_CANT_CREATE_WN) [nsIJSCID.getService]"  nsresult: "0x80570019
> (NS_ERROR_XPC_CANT_CREATE_WN)"  location: "JS frame ::
> file:///C:/Programmas/Firefox/ff30trunk/firefox/components/nsExtensionManager.js
> :: anonymous :: line 1576"  data: no]
I highly doubt and see no way that this has anything to do with this bug. Try a build before this landed to see if it is actually related to this patch.

Comment 9

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060125 Firefox/1.6a1 ID:2006012512
Further, all extensions seem to have the default jigsaw piece for their icon, and some extensions are playing up (DOM Inspector & Talkback are in an internal state of '..will be installed next time you restart firefox', tabmixplus isn't working at all, et al)

Comment 10

[Peter van der Woude [:Peter6]]

(In reply to comment #8)

> I highly doubt and see no way that this has anything to do with this bug. Try a
> build before this landed to see if it is actually related to this patch.
> 

You're right, this started earlier
no message in the 20060124 1118pst build
the message in the 20060124 1442pst build

i filed Bug 324715 for it