Closed
Bug 313174
Opened 20 years ago
Closed 20 years ago
IME composition string isn't rendered as selection text
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: inputmethod, intl, regression)
Attachments
(1 file)
944 bytes,
patch
|
sergei_d
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Bug-org 242315 is fixed. But it may have a regression.
On Be-OS, we don't render the composition string as selection text.
This is serious regression.
Assignee | ||
Comment 1•20 years ago
|
||
Bug-org 242315 -> Bug 242315
Comment 2•20 years ago
|
||
fix is simple, adding || defined(XP_BEOS), as BeOS supports InvertRect
Assignee | ||
Comment 3•20 years ago
|
||
Maybe, fix.
Attachment #200247 -
Flags: superreview?(roc)
Attachment #200247 -
Flags: review?(roc)
Comment 4•20 years ago
|
||
i can review patch from BeOS side - as it worked for me and Koki-san at selection.
But does it need sr ?
Assignee | ||
Comment 5•20 years ago
|
||
Attachment #200247 -
Flags: review?(roc) → review?(sergei_d)
Comment 6•20 years ago
|
||
How it looks in BeOS with patch applied:
http://beos.spb.ru/mozilla/BeIMEInvertRect.png
Comment 7•20 years ago
|
||
Comment on attachment 200247 [details] [diff] [review]
Patch rv1.0
r=sergei_d
Attachment #200247 -
Flags: review?(sergei_d) → review+
Assignee | ||
Comment 8•20 years ago
|
||
looks good.
Comment 9•20 years ago
|
||
sorry, forget to set Haru font for screenshot - problem with Harus is that it
produces wrong spacing (double) for cyrillic letters (my default locale is
Russian) in BeOS. But result is understandable anyway
Assignee | ||
Comment 10•20 years ago
|
||
I can see the selection rendering. It's enough. Thanks.
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 11•20 years ago
|
||
Boris:
Could you superreview to this?
This patch is very simple and this is blocker bug for BeOS user.
# I tried to contact to roc, but I don't have his reply...
![]() |
||
Comment 12•20 years ago
|
||
Comment on attachment 200247 [details] [diff] [review]
Patch rv1.0
sr=bzbarsky, though I have some questions:
1) If it's a blocker, why wasn't blocking? requested? The chance of getting this into 1.8 is about 0 at this point.
2) Why do we need this whitelist of XP* stuff? Why not just USE_INVERT_RECT on anything that's not Mac?
Attachment #200247 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Comment 13•20 years ago
|
||
> 1
Bug 242315 is not going to 1.8 branch.
> 2
Mac is changed by bug 236996.
# And I will rewrite these code in 1.9 cycle.
Assignee | ||
Comment 14•20 years ago
|
||
checked-in to Trunk.
Sergei:
If you need approval for this, you should request it.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 15•20 years ago
|
||
Niels has his own plans about 1.8* - he decided to skip RC1 as far as i know.
Usually it is his job/privilege to set approval requests for 1.8(FF 1.5).
![]() |
||
Comment 16•20 years ago
|
||
Just so people are clear, RC1 is a real RC. That's the code we'll ship unless something comes up that's stop-ship.
Comment 17•20 years ago
|
||
It's clear, however, I sort of hope that (In reply to comment #16)
> Just so people are clear, RC1 is a real RC. That's the code we'll ship unless
> something comes up that's stop-ship.
I'm sort of hoping that that would be the case. Anyway, else I'll just release a build with custom patches, so it's not a major problem.
Assignee | ||
Updated•15 years ago
|
Keywords: inputmethod
You need to log in
before you can comment on or make changes to this bug.
Description
•