Fix strict warning in utils.js

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
trivial
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.69])

Attachments

(1 attachment)

856 bytes, patch
James Ross
: review+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
1047 function prompt(msg, initial, parent, title)
1048 {
1049     var PROMPT_CTRID = "@mozilla.org/embedcomp/prompt-service;1";
1050     var nsIPromptService = Components.interfaces.nsIPromptService;
1051     var ps = Components.classes[PROMPT_CTRID].getService(nsIPromptService);
1052     if (!parent)
1053         parent = window;
1054     if (!title)
1055         title = MSG_PROMPT;
1056     rv = { value: initial };

The last line gives a strict warning because rv is not defined. Micro-patch
coming up.
(Assignee)

Comment 1

12 years ago
Created attachment 200284 [details] [diff] [review]
Patch

Courtesy of Silver for spotting this and fixing it in 0.9.68.5. Let's make
everyone happy and get this on trunk :-)
Attachment #200284 - Flags: review?(silver)
(Assignee)

Updated

12 years ago
Blocks: 299458

Comment 2

12 years ago
Comment on attachment 200284 [details] [diff] [review]
Patch

Micro-review=silver ;)
Attachment #200284 - Flags: review?(silver) → review+

Comment 3

12 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Whiteboard: [cz-0.9.69]
You need to log in before you can comment on or make changes to this bug.