31324 - Bugzilla displays attempted HTML links incorrectly

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P3)

Description

[Jesse Ruderman]

Some bugzilla users attempt to include HTML tags in their posts, for example, 
to link to another bug.  They probably do this because they're used to slashdot-
style linking, and assume that the automatic "Bug #10000" links in other 
people's posts are actually manual links.  The problem isn't that bugzilla 
doesn't allow HTML posts, but that it messes up both the manual link and the 
automatic link (if the anchor text is like "Bug #10000") in this case so that 
other users must type the bug number manually (the horror :)

Bug #31322 shows a few test cases and the results.

Actual results: Bugzilla includes the > in the href and the anchor as part of 
the URL.

Expected results: Link URL is underlined correctly (so it's clickable) but all 
tags are still shown as typed (so pasted html isn't destroyed).  Anchors that 
are bug numbers are also linked to the bug number they refer to.


Related:
Bug #31323, bugzilla should warn users not to use html tags to format messages
Bug #17452, RFE to allow bugzilla comments to be in html format (which probably 
won't be done)

Comment 1

[Jesse Ruderman]

*** Bug 31322 has been marked as a duplicate of this bug. ***

Comment 2

[Ben Bucksch (:BenB)]

At least, correctly delimited URLs are recognized correctly now (IIRC, they
wasn't a month ago): <http://www.mozilla.org>. Tnx terry!

See RFC2396, for which chars are allowed in URIs. "<> (double quote and angle
brackets) are never allowed. 

Proposed fix:
There's no perl/XPCOM-gateway, is there? :-)
Otherwise stop at the first of the above mentioned chars in all cases.

Comment 3

[Terry Weissman]

OK, fixed.  URLs will now never contain ", <, or >.  Bug #31322 now displays
much nicer.

(And no, I did not make any other recent changes to improve "correctly delimited
URLs".)

Comment 4

[Ben Bucksch (:BenB)]

Wow, fast and good fix.

Comment 5

[Jesse Ruderman]

Terry, can you make it also hyperlink things like 
<URL:resource:/res/samples/test0.html>?

Comment 6

[Ben Bucksch (:BenB)]

David, did you try to add such a link to a webpage and open that link? I did try
it, but I don't think, it will work, because anonymous content doesn't have
access to local resources, IIRC.

Comment 7

[Ben Bucksch (:BenB)]

I did *not* try it

webpage = html page on a http server

Comment 8

[Jesse Ruderman]

You're right about that, but I'd still like to see the feature added to 
bugzilla because there are some links that should work, such as finger: links 
(see the first line of comments in bug 33132, and the url of bug 29952).

By the way, you can open those links by right-clicking and selecting "open in 
new window".  Just filed that as bug 35273.

Comment 9

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 10

[Gervase Markham [:gerv]]

This bug has not been touched for more than nine months. In most cases, that 
means it has "slipped through the net". Please could the owner take a moment to 
add a comment to the bug with current status, and/or close it.

Thank you :-)

Gerv

Comment 11

[Andreas Franke (gone)]

-> Bugzilla product, User Interface component, reassigning.

Comment 12

[Christian Reis]

Uhm, is this solved or not? Could somebody please summarize what is to be done
here so I can go and do it?

Comment 13

[Dave Miller [:justdave]]

Jesse, Ben, you guys were the ones commenting after it was supposedly fixed
before.  What else still needs to be done?  It's hard to tell from the comments.

Comment 14

[Ben Bucksch (:BenB)]

Bug is fixed. It has been reopened by Jesse in April 2000 to add more URL
schemes, but that is arguable not not exactly topic of this bug. Please open a
new one for that. Marking FIXED again.