313256 - Update CSS for attachment comment in real time to private comments

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[André Batosti]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050725 Firefox/1.0.6 (Ubuntu package 1.0.6)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050725 Firefox/1.0.6 (Ubuntu package 1.0.6)

The bz_private style is used to display private comments.  If the status is
changed for the attachment the style of comment textbox will be changed in real
time.

Reproducible: Always

Comment 1

[André Batosti]

Attachment: batosti_v1

Comment 2

[Vlad Dascalu]

Comment on attachment 200635 [details] [diff] [review]
batosti_v1

-        <textarea wrap="soft" id="commment" name="comment" rows="6" cols="80"></textarea>
+        <textarea wrap="soft" id="comment" name="comment" rows="6" cols="80"></textarea>

This was moved in bug 329323, and it's only for 2.20 and 2.22 (trunk has it fixed).

In addition, including this here makes your patch bitrotten on trunk (applying it fails). Also, this specific change should be commited in 2.20 as well (the target of this bug is 2.20).

So please make a patch that reflects only the bug summary.

Also, what's up with this
-    document.refresh();
thing?

Comment 3

[Vlad Dascalu]

I meant 'the target of this bug is NOT 2.20' in my previous comment.

Comment 4

[André Batosti]

Attachment: batosti_v1_fix

Comment 5

[Vlad Dascalu]

Comment on attachment 214177 [details] [diff] [review]
batosti_v1_fix

This works if we're going to support only DOM level 1 compliant browsers.

Upon checkin, document.getElementById *could* be replaced with a larger function, in order to add support for a wide range of browsers. This is completely optional.

One possible version could be:

function returnObjById( id )
{
    if (document.getElementById)
        var returnVar = document.getElementById(id);
    else if (document.all)
        var returnVar = document.all[id];
    else if (document.layers)
        var returnVar = document.layers[id];
    return returnVar;
}

Google.com used to use:

function el(id) {
	if (document.getElementById) {
		return document.getElementById(id);
	} else if (window[id]) {
		return window[id];
	}

	return null;
}

The one who sets the approval? flag could specify its preference for one of those 3 versions.

Comment 6

[Frédéric Buclin]

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.26; previous revision: 1.25
done