Update CSS for attachment comment in real time to private comments

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
User Interface
--
enhancement
RESOLVED FIXED
13 years ago
11 years ago

People

(Reporter: André Batosti, Assigned: André Batosti)

Tracking

unspecified
Bugzilla 3.0
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.28 KB, patch
Vlad Dascalu
: review+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050725 Firefox/1.0.6 (Ubuntu package 1.0.6)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050725 Firefox/1.0.6 (Ubuntu package 1.0.6)

The bz_private style is used to display private comments.  If the status is
changed for the attachment the style of comment textbox will be changed in real
time.

Reproducible: Always

Updated

13 years ago
Assignee: myk → batosti
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.22
(Assignee)

Comment 1

13 years ago
Created attachment 200635 [details] [diff] [review]
batosti_v1
Attachment #200635 - Flags: review?(bugreport)

Updated

12 years ago
Status: NEW → ASSIGNED
Summary: update css for attachment comment in real time to private comments → Update CSS for attachment comment in real time to private comments

Comment 2

12 years ago
Comment on attachment 200635 [details] [diff] [review]
batosti_v1

-        <textarea wrap="soft" id="commment" name="comment" rows="6" cols="80"></textarea>
+        <textarea wrap="soft" id="comment" name="comment" rows="6" cols="80"></textarea>

This was moved in bug 329323, and it's only for 2.20 and 2.22 (trunk has it fixed).

In addition, including this here makes your patch bitrotten on trunk (applying it fails). Also, this specific change should be commited in 2.20 as well (the target of this bug is 2.20).

So please make a patch that reflects only the bug summary.

Also, what's up with this
-    document.refresh();
thing?
Attachment #200635 - Flags: review?(bugreport) → review-

Comment 3

12 years ago
I meant 'the target of this bug is NOT 2.20' in my previous comment.
(Assignee)

Comment 4

12 years ago
Created attachment 214177 [details] [diff] [review]
batosti_v1_fix
Attachment #200635 - Attachment is obsolete: true
Attachment #214177 - Flags: review?(vladd)

Updated

12 years ago
Target Milestone: Bugzilla 2.22 → Bugzilla 2.24

Comment 5

12 years ago
Comment on attachment 214177 [details] [diff] [review]
batosti_v1_fix

This works if we're going to support only DOM level 1 compliant browsers.

Upon checkin, document.getElementById *could* be replaced with a larger function, in order to add support for a wide range of browsers. This is completely optional.

One possible version could be:

function returnObjById( id )
{
    if (document.getElementById)
        var returnVar = document.getElementById(id);
    else if (document.all)
        var returnVar = document.all[id];
    else if (document.layers)
        var returnVar = document.layers[id];
    return returnVar;
}

Google.com used to use:

function el(id) {
	if (document.getElementById) {
		return document.getElementById(id);
	} else if (window[id]) {
		return window[id];
	}

	return null;
}

The one who sets the approval? flag could specify its preference for one of those 3 versions.
Attachment #214177 - Flags: review?(vladd) → review+

Updated

12 years ago
Flags: approval?
Flags: approval? → approval+

Comment 6

12 years ago
Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.26; previous revision: 1.25
done
Severity: normal → enhancement
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.