3133 - Window title bar displays "- Failed"

Status: VERIFIED FIXED

(Core Graveyard :: Viewer App, defect, P2)

Description

[Pierre Saslawsky]

On the Mac, the window title bars in Viewer show the suffix "- Failed".
This is related to the code you have checked in nsBrowserWindow.cpp on Tuesday.

The Service Manager cannot create an instance of the StringBundleService because
of NS_ERROR_FACTORY_NOT_REGISTERED.

You either have to auto-register the StringBundle factory (good) or to
explicitely register it in the various copies of nsSetupRegistry.cpp (not so
good).

Comment 1

[Erik van der Poel]

Frank, could you update your Mac tree, and look into this please?
(I don't have a Mac.)

Comment 2

[Pierre Saslawsky]

Erik, no need to have a Mac: just tell me where and how you register the
factory.

Comment 3

[Erik van der Poel]

It is both automatically (NSRegisterSelf) and manually (nsSetupRegistry.cpp)
registered. Should one of them (the manual one) be deleted? If so, why is this
behavior different between the Mac and (Windows, Unix)?

Comment 4

[Pierre Saslawsky]

Suddenly, I have a doubt... Did you build a shared lib and add it to
the Mac build system? You did not check it in just for Windows and Unix, did
you?

Comment 5

[Erik van der Poel]

Frank built the Mac project file for me. He just discovered a bug in it. He
said he will check it in when the tree opens (or maybe on Monday, so as not to
break the tree over the weekend).

Comment 6

[Pierre Saslawsky]

I get it. Franck, if you need some help...

Comment 7

[Frank Tang]

I change the project file and make sure the export symbol setting is correct. It
should be fixed now.

Comment 8

[Claudius Gayle]

marking VERIFIED...for Mar28 Mac Viewer although the date and application isn't relevant at this point.