DoSearch: for "post", input is always the empty string?

RESOLVED INVALID

Status

SeaMonkey
Search
RESOLVED INVALID
12 years ago
6 years ago

People

(Reporter: Biesinger, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

The block around
http://lxr.mozilla.org/seamonkey/source/xpfe/components/search/src/nsInternetSearchService.cpp#4100
uses the variable "input". This is inside a block that checks for method == post.

However, the only assignment to input that I can find is in
http://lxr.mozilla.org/seamonkey/source/xpfe/components/search/src/nsInternetSearchService.cpp#4063,
which checks for method=="get" - clearly, get and post are mutually exclusive.
It seems a very old regression. bug 25034 ...?
http://bonsai.mozilla.org/cvsview2.cgi?command=DIFF&subdir=mozilla%2Fxpfe%2Fcomponents%2Fsearch%2Fsrc&file=nsInternetSearchService.cpp&rev1=1.45&rev2=1.47&whitespace_mode=show&diff_mode=context

I wonder if this would help to implement the POST method search. This
is not a big problem at least for Firefox, as it never calls DoSearch().
I'm not too sure about Seamonkey, but GetInternetSearchURL() does not
work with POST method anyway, so...
Product: Core → SeaMonkey

Comment 2

6 years ago
This code does not exist any more. We are now using the Toolkit Search Service.
=>INVALID
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.