313385 - The update history is broken if it has non-ASCII char

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We have a report in Bugzilla-jp. But this bug is not comfirmed by me.
He(or she) said, update history is broken if it has Japanese character.
The update history file is written in UTF-8. But we don't read the file as UTF-8.

He(or she) proposes a patch. See this.
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2933&action=view

If this bus is confirmed, we should block final release.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

screenshot1(current)
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2934&action=view
screenshot2(with the patch)
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2935&action=view

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0 (by [e-mail])

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: screenshot1

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: screenshot2

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase1

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase2

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I confirmed this bug. And I confirmed the patch works fine.
Let's go to 1.8.

Comment 8

[Darin Fisher]

Comment on attachment 200442 [details] [diff] [review]
Patch rv1.0 (by [e-mail])

r=darin

This is a must fix for non-english builds of FF.  Thanks for the patch!

Comment 9

[Darin Fisher]

fixed-on-trunk

Comment 10

[Darin Fisher]

fixed1.8