313419 - Don't kill <area>s outside <map>s

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We currently don't put <area>s outside map-elements into the contentmodel.
There's not really a good reason for this since they won't do anything and they
won't affect rendering. IE puts them in the DOM so it should be safe.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 200470 [details] [diff] [review]
Patch to fix

You're going to need to have to change the element table definition of
eHTMLTag_area so that regular elements will be able to contain it.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch v2

Fix comments by blake

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 200473 [details] [diff] [review]
Patch v2

>Index: src/nsElementTable.cpp
>-DECL_TAG_LIST(gAreaParent,{eHTMLTag_map})
...
>-    /*parent,incl,exclgroups*/          kNone, kInlineEntity, kSelf,
>+    /*parent,incl,exclgroups*/          kHeadMisc, kInlineEntity, kSelf,
>     /*special props, prop-range*/       kNonContainer,kDefaultPropRange,
>-    /*special parents,kids,skip*/       &gAreaParent,0,eHTMLTag_unknown,
>+    /*special parents,kids,skip*/       0,0,eHTMLTag_unknown,

I think you want (kFlowEntity | kHeadMisc) as the parent model, and I think I'd
feel better leaving the "special parent" to seperate out <map> as being one.
(maps can probably contain areas even with this patch because area is map's
"special child", but making the relationship explicit seems like the right way
to go).

Other than that, looks good.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch v3

We talked some more and agreed to try to compleatly kill the special relationship between map and area which this patch does. However I need to run some more testing on this, but I can't fully test this until bug 312592 is fixed since that bug causes the html sink to not create areas outside the map even if the parser allows it.

So holding off review requests for now