313464 - Change in French search plugins: Google searchplugin

Status: VERIFIED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Benoit]

We would like to add a good French dictionary for our users in addition to Wikipedia, as there is currently no solution like a localized answers.com which would provide both (dictionary+encyclopedia). We currently have no dictionary at all (we had one for the Firefox 1.0 release, but the service was discontinued since).

To not increase the number of search engines, we would like to remove Creative Commons, which is not widely used and, by the way, the only search plugin _not_ in French.

We have chosen Mediadico for now, as it is quite comprehensive (including recent words), easy and pleasant to use. The people at Mediadico were also kind enough to provide us a functional plugin (see URL for this bug). 

Note: others solutions like the TLF (Trésor de la langue française) were considered and may take this place in the future if they evolve to (at least) provide inter-definition links. For now (1.5), Mediadico is probably the best pick.

List of search plugins before the change:
Google
Yahoo
Amazon
Creative Commons
eBay
Wikipedia

List of search plugins after the change:
Google
Yahoo
Amazon
Mediadico
eBay
Wikipedia

Comment 1

[Benoit]

Attachment: MediaDICO search plugin

Comment 2

[Benoit]

Attachment: Icon for the plugin

Comment 3

[Benoit]

Moving to the l10n component to get the approval-l10n flag, blocking bug #307393 (trademark review) as suggested by Pike on IRC.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 200492 [details]
MediaDICO search plugin

From a general point of view, this change looks ok to me.

><input name="alea" value="2005">

What does this do?

><browser
> update="http://www.dictionnaire-mediadico.com/MediaDICO.src" 
> updateIcon="http://www.dictionnaire-mediadico.com/MediaDICO.gif" 
> updateCheckDays="3" 

update should be following the scheme laid out in bug 306576. (I don't think that a -fr-FR suffix makes sense here, so just using the general filename will be good)

Comment 5

[Benoit]

(In reply to comment #4)
> ><input name="alea" value="2005">
> 
> What does this do?

I asked to our contact at mediadico, here is his answer (roughly translated):

"The parameter alea=2005 is not used as a key. The parameter indicates the version of the dictionary. Search will still work if it is of any random numerical value though."

Comment 6

[Cédric Corazza]

Attachment: MediaDICO searchplugin

Changes done

Comment 7

[Cédric Corazza]

Attachment: MediaDICO icon

Renaming the icon filename

Comment 8

[Cédric Corazza]

As trademark review restarts from scratch, maybe this bug could be closed ?

Comment 9

[Axel Hecht [:Pike]]

There seems to be a type ("action" instead of "auction") in the ebay plugin.
The google plugin lacks a line ending (it's on char short on linux, too).

The rest looks good.

Comment 10

[Cédric Corazza]

(In reply to comment #9)
All is fixed now and committed into the cvs.

Comment 11

[Cédric Corazza]

Attachment: Google searchplugin diff

Comment 12

[Cédric Corazza]

As we planned to keep the same searchplugin as the en-US one, here's the diff to match it.

Comment 13

[Benoit]

Attachment: Replacing mozilla.org by mozilla.com, adding a link to mozilla-europe.org/fr/ just below

Change requested by Pike on IRC.

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 203095 [details] [diff] [review]
Replacing mozilla.org by mozilla.com, adding a link to mozilla-europe.org/fr/ just below

thanks.

Comment 15

[Benoit]

(In reply to comment #13)
> Created an attachment (id=203095) [edit]

Checked in. Is the trademark review considered done with this?

Comment 16

[Jay Patel [:jay]]

Resolving this fixed, since it looks like Axel gave approval for checkin and things look good with the latest FR candidate.

Comment 17

[Jay Patel [:jay]]

v.fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8) Gecko/20051111 Firefox/1.5

Search plugins are all there and the changes to the Bookmarks file are in.