313731 - Location bar changes height when clicking on Account name and/or Folder

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051025 SeaMonkey/1.1a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051025 SeaMonkey/1.1a

When clicking on an Account name, the toolbar showing the Location Bar gets smaller, while clicking on a folder inside an account (and so the search filter shows up), the toolbar gets taller, which is a little annoying.

Reproducible: Always

Steps to Reproduce:




My guess is that the "Clear" button is too tall (or the Location Bar is too small).
Seen on my build with GTK2 and xft (no freetype), current trunk.

Comment 1

[Giacomo Magnini]

Attachment: Screenshot of Location Bar when clicking on an Account

Comment 2

[Giacomo Magnini]

Attachment: Screenshot of Location Bar when clicking on an Account

Comment 3

[Giacomo Magnini]

Attachment: Screenshot of Location Bar when clicking on a folder

Comment 4

[Giacomo Magnini]

Attachment: Side-by-Side comparision, showing the problem in full

Comment 5

[[e-mail]]

Attachment: Proposed patch

Can you try this patch for me please?

Comment 6

[Giacomo Magnini]

Works like a charm for me, but will give you r- because the same patch is needed for modern theme, and especially because denying a r request is something I've never done before in my life! :-D
BTW, I've not enough rights to set r-... ;)

Comment 7

[Giacomo Magnini]

Attachment: Modern with Account selected

Comment 8

[Giacomo Magnini]

Attachment: Modern with Inbox selected

Comment 9

[Giacomo Magnini]

The same patch applied to modern, fixes the display problem under such theme for me.

Comment 10

[[e-mail]]

Attachment: Proposed patch

Comment 11

[Karsten Düsterloh]

Comment on attachment 200752 [details] [diff] [review]
Proposed patch

I don't see the problem with Classic on Win2k, only with Modern (trunk build 2005-10-24). I don't see the problem on Mac with Classic, only with Modern (trunk build 2005-10-29).
Is this problem visible in Linux/Classic? (I'm not near a Linux box until mid next week.)

BTW: On Mac/Classic, the dropmarker is still visible inside the location bar's menulist (#locationFolders .menulist-dropmarker), thus shown twice. Mac/Modern is okay.

Comment 12

[Karsten Düsterloh]

Attachment: double folder icon in Classic Mac theme

Comment 13

[[e-mail]]

Attachment: Combined patch

This also removes an extraneous style rule from the mac menulist CSS.

Comment 14

[Karsten Düsterloh]

Comment on attachment 201298 [details] [diff] [review]
Combined patch

Wiggling gone, Mac looking fine now.

Comment 15

[[e-mail]]

Fix checked in.

Comment 16

[Steffen Wilberg]

Comment on attachment 200734 [details] [diff] [review]
Proposed patch

This is part of attachment 201298 [details] [diff] [review] ("combined patch" in this bug).