Closed Bug 31382 Opened 25 years ago Closed 24 years ago

"All Files", "HTML Files (*.htm;, *.html)", "Text Files(*.txt) hardcoded

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: rchen, Assigned: pavlov)

References

Details

(Whiteboard: [nsbeta2+]) 

Go to Browser menu, File | Open File, in Open File dialog, the strings "All 
Files" in "Files of type" are hardcoded in 

widget\src\xpwidgets\nsFileSpecWithUIImpl.cpp as

		*nextTitle++ = "All Files";	
		*nextTitle++ = "HTML Files (*.htm; *.html)";


The same problem happens in Composer, File | File open. 

Please remove them to DTD or properties.
Blocks: 12394
reassigning to pinkerton
Assignee: trudelle → pinkerton
Summary: "All Files", "HTML Files (*.htm;, *.html)", "Text Files(*.txt) hardcoded → "All Files", "HTML Files (*.htm;, *.html)", "Text Files(*.txt) hardcoded
accepting for m16
Status: NEW → ASSIGNED
Target Milestone: M16
Blocks: 31406
*** Bug 31755 has been marked as a duplicate of this bug. ***
Blocks: 31288
moving all defects not directly related to P0 beta2 features off to M18.
Target Milestone: M16 → M18
Reconsider this for beta 2. It's bad enough that we leave it in English in 
beta1, but we cannot ship beta 2 the same way. Let us know if you need help, but 
this has to be in for beta2.
Assignee: pinkerton → danm
Status: ASSIGNED → NEW
reassigning to danm for M16
It's still M18. can you modify it?
Mass moving M18 bugs to M19
Target Milestone: M18 → M19
Peter, I don't think you read my comment. We need hardcoded strings externalized 
by beta2, that we will be localizing. Please reconsider TFV and let us know if 
you need help.
Keywords: beta2
I add beta2 keyword. danm, can you fix it by M17? Thanks.
Keywords: nsbeta2
Putting on [nsbeta2+] radar for beta2 fix.
Whiteboard: [nsbeta2+]
Moving undated nsbeta2+ non-feature bugs to M18.
Target Milestone: M19 → M18
taking
Assignee: danm → pavlov
fixed with new file picker
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
note: don't use nsFileSpecWithUIImpl.  It is going away before RTM.

The string bundle files are in xpfe/components/filepicker/res/locale
verified fixed 20000608nn win32/linux (mac uses native resource forks).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.